https://bugzilla.redhat.com/show_bug.cgi?id=2145834 Jonathan Wright <jonathan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #14 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- (In reply to dave@xxxxxxxxxxxx from comment #13) > > [!]: Uses parallel make %{?_smp_mflags} macro. > > Switched to use %make_build and %make_install instead of calling make > directly, as I believe this is preferred, and should handle smp macro etc? Yes perfect! I should've caught that in the review anyway. > > [!]: Package requires other packages for directories it uses. > > [!]: Package must own all directories that it creates. > > Added additional entries in %files section, for the directories reported. > > I'm a little confused by the docs of how to identify these, though: > > "It’s easy to find unowned directories with rpmls from rpmdevtools or rpm > -qlv." > > https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ > #_tools_to_help > > ... I'm not clear exactly *how* it's easy to find the directories with those > tools? Something simple is probably going right over my head, though. > I've always just used the output of fedora-review. It's very easy to run, just `fedora-review -b XXXXXX` with the bug number. You can use -n to pass it a local build. I generally run this against my packages before submitting for review just to speed up the review process because the reviewer is going to run it anyway and tell me to fix stuff :) > Fingers crossed this addresses everything. Thanks again for all of the > prompt review actions! Looks good to me now! Package is approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2145834 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
