https://bugzilla.redhat.com/show_bug.cgi?id=2145834 --- Comment #13 from dave@xxxxxxxxxxxx <dave@xxxxxxxxxxxx> --- Spec URL: https://dctrud.fedorapeople.org/singularity-ce.spec SRPM URL: https://dctrud.fedorapeople.org/singularity-ce-3.10.4-1.fc37.src.rpm Updated the files above. > You need to add an ExclusiveArch tag. Done > [!]: Uses parallel make %{?_smp_mflags} macro. Switched to use %make_build and %make_install instead of calling make directly, as I believe this is preferred, and should handle smp macro etc? > [!]: Package requires other packages for directories it uses. > [!]: Package must own all directories that it creates. Added additional entries in %files section, for the directories reported. I'm a little confused by the docs of how to identify these, though: "It’s easy to find unowned directories with rpmls from rpmdevtools or rpm -qlv." https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/#_tools_to_help ... I'm not clear exactly *how* it's easy to find the directories with those tools? Something simple is probably going right over my head, though. Fingers crossed this addresses everything. Thanks again for all of the prompt review actions! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2145834 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
