[Bug 1684603] Review Request: bCNC - GRBL CNC command sender, autoleveler and G-code editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1684603



--- Comment #33 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> ---
(In reply to Benson Muite from comment #32)

> bCNC.noarch: W: python-bytecode-without-source
> /usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.
> cpython-311.opt-1.pyc
> bCNC.noarch: W: python-bytecode-without-source
> /usr/lib/python3.11/site-packages/bCNC/lib/python_utils/__pycache__/compat.
> cpython-311.pyc
>
It seems it's bundled python3-utils and python3-numpy-stl. I tried to unbundle
them (hopefully, I can't test it at the moment). Also it seems there is some
more code bundled. I was able to recognize svgcode 0.2, it's probably not worth
to package it (one class, 80 lines). I added the "bundled" record for it.

> bCNC.noarch: E: non-executable-script
> /usr/lib/python3.11/site-packages/bCNC/__main__.py 644 /usr/bin/env python3
> bCNC.noarch: E: non-executable-script
> /usr/lib/python3.11/site-packages/bCNC/bmain.py 644 /usr/bin/env python3
>
Dropped the shebangs.

> bCNC.noarch: W: no-manual-page-for-binary bCNC
> bCNC.noarch: W: invalid-license GPL-2.0-only
> bCNC.noarch: W: invalid-license GPL-2.0-or-later
> bCNC.noarch: W: invalid-license BSD-3-Clause
>
SPDX, probably OK. 

> bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/exclamation.gif
> /usr/share/bCNC/icons/debug.gif
> bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pan.gif
> /usr/share/bCNC/icons/move.gif
> bCNC.noarch: W: files-duplicate /usr/share/bCNC/icons/pocket.gif
> /usr/share/bCNC/icons/offset.gif
>
Upstream reuses the same icons, I think it's not worth to add hacks/symlinks to
spare few bytes even if upstream could change the icons anytime without prior
notice.

> bCNC.noarch: W: dangling-symlink
> /usr/lib/python3.11/site-packages/bCNC/pendant/jquery-2.1.4.min.js
> /usr/share/javascript/jquery/latest/jquery.min.js
>
Not clean but intended.

Spec URL: https://jskarvad.fedorapeople.org/bCNC/bCNC.spec
SRPM URL:
https://jskarvad.fedorapeople.org/bCNC/bCNC-0.9.14.52~20221017git523f1ec7-5.fc35.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1684603
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux