[Bug 2116084] Review Request: python-pydiffx - Python implementation of the DiffX specification

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2116084



--- Comment #7 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> ---
Spec URL: https://jonathanspw.fedorapeople.org/python-pydiffx.spec
SRPM URL:
https://jonathanspw.fedorapeople.org/python-pydiffx-1.1-1.fc38.src.rpm

(In reply to Elliott Sales de Andrade from comment #6)
> Is the MIT license the SPDX identifier or the old identifier?

Both

> You also don't need BuildRequires on six and setuptools as you have a
> %generate_buildrequires section. A runtime Requires on six is also not
> needed as it's generated from metadata. 

The BR on six is required.  Upstream doesn't properly provide the info for the
%generate_buildrequires to work.

I dropped the runtime requirement on it.

> Also missing a space in between "diffs,in" in the description.

Fixed


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2116084
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux