[Bug 2143910] Review Request: python-uhashring - uhashring implements consistent hashing in pure Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2143910



--- Comment #3 from Alfredo Moralejo <amoralej@xxxxxxxxxx> ---
WRT the reported issues:

1. The package is not in latest version

Latest version, 2.2 fails to build because the package was moved to hatch build
system in:

https://github.com/ultrabug/uhashring/commit/744f61fbd2ef71f7479dd99411627f5c512d402e

The package config has been moved to pyproject.tml with a format that is not
properly managed by %pyproject_wheel macro that fails with:

ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found

The reason is taht current tox and tox-current-env only supports pyproject.toml
with legacy_tox_ini format (https://tox.wiki/en/latest/example/basic.html)
while this project does not have legacy_tox_ini:

https://github.com/ultrabug/uhashring/blob/master/pyproject.toml

Checking the differences in code between uhashring 2.1 and 2.2:

https://github.com/ultrabug/uhashring/compare/2.1...2.2

I've noticed there are no relevant changes in code and 2.1 still had the old
tox.ini, setup.py files, so i decided to package 2.1 instead of reverting
specific patches at packaging or other hacky solutions.


2. Changelog is missing "-" before version

fixed in updated spec file

Spec URL:
https://raw.githubusercontent.com/amoralej/packages/main/python-uhashring.spec
SRPM URL:
https://github.com/amoralej/packages/raw/main/python-uhashring-2.1-1.fc38.src.rpm


3. pyproject-rpm-macros BR is not required here

fixed in updated spec file


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2143910
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux