https://bugzilla.redhat.com/show_bug.cgi?id=2119830 Kalvin McCallum <kalvin_mccallum@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kalvin_mccallum@xxxxxxxxxxx | |.edu --- Comment #5 from Kalvin McCallum <kalvin_mccallum@xxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "Apache License", "*No copyright* MIT License GNU General Public License Apache License 2.0", "*No copyright* MIT License", "*No copyright* Boost Software License 1.0", "MIT License". 351 files have unknown license. Detailed output of licensecheck in /home/kalvinmccallum/2119830-opentelemetry-cpp/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/opentelemetry [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/opentelemetry [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/cmake(catalyst- devel, libarcus-devel, PackageKit-Qt5-devel, paraview-devel, SDL2_image-devel, kqtquickcharts, libsavitar-devel, gtk-doc, pulseaudio-libs-devel, openshadinglanguage-devel, priv_wrapper, ginac- devel, uid_wrapper, qjson-qt5-devel, boost-devel, qjson-devel, flang- devel, qt5-qtbase, libssh-devel, leatherman-devel, marble-widget- qt5-devel, marble-astro-devel, openobex-devel, rizin-devel, cmake- filesystem, telepathy-qt5-devel) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opentelemetry-cpp-devel , opentelemetry-proto , opentelemetry-proto- devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define cpp_version 1.6.0, %define proto_version 0.18.0 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 6 opentelemetry-cpp.x86_64: E: undefined-non-weak-symbol /usr/lib64/libopentelemetry_exporter_ostream_metrics.so _ZNK13opentelemetry2v13sdk8resource8Resource13GetAttributesEv (/usr/lib64/libopentelemetry_exporter_ostream_metrics.so) opentelemetry-cpp.x86_64: E: undefined-non-weak-symbol /usr/lib64/libopentelemetry_exporter_otlp_http_client.so _ZN13opentelemetry2v13sdk6common12internal_log16GlobalLogHandler18GetHandlerAndLevelEv (/usr/lib64/libopentelemetry_exporter_otlp_http_client.so) opentelemetry-cpp.x86_64: E: shared-library-without-dependency-information /usr/lib64/libopentelemetry_exporter_otlp_grpc_log.so opentelemetry-cpp.x86_64: E: shared-library-without-dependency-information /usr/lib64/libopentelemetry_version.so opentelemetry-cpp-devel.x86_64: W: only-non-binary-in-usr-lib opentelemetry-proto.x86_64: W: no-documentation opentelemetry-proto-devel.x86_64: W: no-documentation opentelemetry-cpp-devel.x86_64: W: no-documentation opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libhttp_client_nosend.so libhttp_client_nosend.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_common.so libopentelemetry_common.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_in_memory.so libopentelemetry_exporter_in_memory.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_jaeger_trace.so libopentelemetry_exporter_jaeger_trace.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_ostream_metrics.so libopentelemetry_exporter_ostream_metrics.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_ostream_span.so libopentelemetry_exporter_ostream_span.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_otlp_grpc.so libopentelemetry_exporter_otlp_grpc.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_otlp_grpc_log.so libopentelemetry_exporter_otlp_grpc_log.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_otlp_grpc_metrics.so libopentelemetry_exporter_otlp_grpc_metrics.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_otlp_http.so libopentelemetry_exporter_otlp_http.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_otlp_http_client.so libopentelemetry_exporter_otlp_http_client.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_exporter_otlp_http_metric.so libopentelemetry_exporter_otlp_http_metric.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_http_client_curl.so libopentelemetry_http_client_curl.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_metrics.so libopentelemetry_metrics.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_otlp_recordable.so libopentelemetry_otlp_recordable.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_resources.so libopentelemetry_resources.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_trace.so libopentelemetry_trace.so opentelemetry-cpp.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_version.so libopentelemetry_version.so opentelemetry-proto.x86_64: E: invalid-soname /usr/lib64/libopentelemetry_proto.so libopentelemetry_proto.so opentelemetry-cpp-debuginfo.x86_64: W: invalid-license ASL-2.0 opentelemetry-cpp.x86_64: W: invalid-license ASL-2.0 opentelemetry-cpp-debugsource.x86_64: W: invalid-license ASL-2.0 opentelemetry-proto.x86_64: W: invalid-license ASL-2.0 opentelemetry-proto-devel.x86_64: W: invalid-license ASL-2.0 opentelemetry-cpp-devel.x86_64: W: invalid-license ASL-2.0 opentelemetry-cpp.x86_64: E: description-line-too-long A language-specific implementation of OpenTelemetry in C++. OpenTelemetry is a collection of tools, opentelemetry-cpp.x86_64: E: description-line-too-long APIs, and SDKs. Use it to instrument, generate, collect, and export telemetry data opentelemetry-cpp.x86_64: E: description-line-too-long (metrics, logs, and traces) to help you analyze your software's performance and behavior. 6 packages and 0 specfiles checked; 26 errors, 10 warnings, 26 badness; has taken 6.7 s Unversioned so-files -------------------- opentelemetry-cpp: /usr/lib64/libhttp_client_nosend.so opentelemetry-cpp: /usr/lib64/libopentelemetry_common.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_in_memory.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_jaeger_trace.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_ostream_metrics.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_ostream_span.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_otlp_grpc.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_otlp_grpc_log.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_otlp_grpc_metrics.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_otlp_http.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_otlp_http_client.so opentelemetry-cpp: /usr/lib64/libopentelemetry_exporter_otlp_http_metric.so opentelemetry-cpp: /usr/lib64/libopentelemetry_http_client_curl.so opentelemetry-cpp: /usr/lib64/libopentelemetry_metrics.so opentelemetry-cpp: /usr/lib64/libopentelemetry_otlp_recordable.so opentelemetry-cpp: /usr/lib64/libopentelemetry_resources.so opentelemetry-cpp: /usr/lib64/libopentelemetry_trace.so opentelemetry-cpp: /usr/lib64/libopentelemetry_version.so opentelemetry-proto: /usr/lib64/libopentelemetry_proto.so Source checksums ---------------- https://github.com/open-telemetry/opentelemetry-proto/archive/v0.18.0/opentelemetry-proto-0.18.0.tar.gz : CHECKSUM(SHA256) this package : 134ce87f0a623daac19b9507b92da0d9b82929e3db796bba631e422f6ea8d3b3 CHECKSUM(SHA256) upstream package : 134ce87f0a623daac19b9507b92da0d9b82929e3db796bba631e422f6ea8d3b3 https://github.com/open-telemetry/opentelemetry-cpp/archive/v1.6.0/opentelemetry-cpp-1.6.0.tar.gz : CHECKSUM(SHA256) this package : 802cf9132ee847bd1c72b72bd8116055fd7e78f60a44bb9c10225b41f5e35bff CHECKSUM(SHA256) upstream package : 802cf9132ee847bd1c72b72bd8116055fd7e78f60a44bb9c10225b41f5e35bff Requires -------- opentelemetry-cpp (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgmock.so.1.12.1()(64bit) libgrpc++.so.1.48()(64bit) libgtest.so.1.12.1()(64bit) libm.so.6()(64bit) libopentelemetry_common.so()(64bit) libopentelemetry_exporter_otlp_http_client.so()(64bit) libopentelemetry_http_client_curl.so()(64bit) libopentelemetry_otlp_recordable.so()(64bit) libopentelemetry_proto.so()(64bit) libopentelemetry_resources.so()(64bit) libprotobuf.so.30()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libthrift-0.14.0.so()(64bit) opentelemetry-proto rtld(GNU_HASH) opentelemetry-cpp-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) opentelemetry-cpp(x86-64) opentelemetry-proto (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgrpc++.so.1.48()(64bit) libprotobuf.so.30()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) opentelemetry-proto-devel (rpmlib, GLIBC filtered): opentelemetry-proto(x86-64) opentelemetry-cpp-debuginfo (rpmlib, GLIBC filtered): opentelemetry-cpp-debugsource (rpmlib, GLIBC filtered): Provides -------- opentelemetry-cpp: libhttp_client_nosend.so()(64bit) libopentelemetry_common.so()(64bit) libopentelemetry_exporter_in_memory.so()(64bit) libopentelemetry_exporter_jaeger_trace.so()(64bit) libopentelemetry_exporter_ostream_metrics.so()(64bit) libopentelemetry_exporter_ostream_span.so()(64bit) libopentelemetry_exporter_otlp_grpc.so()(64bit) libopentelemetry_exporter_otlp_grpc_log.so()(64bit) libopentelemetry_exporter_otlp_grpc_metrics.so()(64bit) libopentelemetry_exporter_otlp_http.so()(64bit) libopentelemetry_exporter_otlp_http_client.so()(64bit) libopentelemetry_exporter_otlp_http_metric.so()(64bit) libopentelemetry_http_client_curl.so()(64bit) libopentelemetry_metrics.so()(64bit) libopentelemetry_otlp_recordable.so()(64bit) libopentelemetry_resources.so()(64bit) libopentelemetry_trace.so()(64bit) libopentelemetry_version.so()(64bit) opentelemetry-cpp opentelemetry-cpp(x86-64) opentelemetry-cpp-devel: cmake(opentelemetry-cpp) opentelemetry-cpp-devel opentelemetry-cpp-devel(x86-64) opentelemetry-proto: libopentelemetry_proto.so()(64bit) opentelemetry-proto opentelemetry-proto(x86-64) opentelemetry-proto-devel: opentelemetry-proto-devel opentelemetry-proto-devel(x86-64) opentelemetry-cpp-debuginfo: debuginfo(build-id) libhttp_client_nosend.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_common.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_in_memory.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_jaeger_trace.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_ostream_metrics.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_ostream_span.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_otlp_grpc.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_otlp_grpc_log.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_otlp_grpc_metrics.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_otlp_http.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_otlp_http_client.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_exporter_otlp_http_metric.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_http_client_curl.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_metrics.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_otlp_recordable.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_resources.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_trace.so-1.6.0-2.fc38.x86_64.debug()(64bit) libopentelemetry_version.so-1.6.0-2.fc38.x86_64.debug()(64bit) opentelemetry-cpp-debuginfo opentelemetry-cpp-debuginfo(x86-64) opentelemetry-cpp-debugsource: opentelemetry-cpp-debugsource opentelemetry-cpp-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2119830 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Perl, Python, fonts, PHP, Java, Ocaml, SugarActivity, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119830 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
