https://bugzilla.redhat.com/show_bug.cgi?id=2126348 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Jitka Plesnikova from comment #4) > > BuildRequires > > FIX: Please add build-requires: > <...> > Almost all missing dependencies were added only one is missing. > FIX: Add BR - perl(Config) - spec file:54 +BuildRequires: perl(Config) Ok. > > FIX: Please add run-requires 'perl(constant)' > Still need to be fixed # Runtime +Requires: perl(constant) Requires: perl(XSLoader) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) @@ -63,6 +63,7 @@ Summary: Tests for %{name} Requires: %{name} = %{?epoch:%{epoch}:}%{version}-%{release} Requires: perl(Test::Harness) +Requires: perl(constant) The run-require should be added only to sub-package perl-Tickit-tests. FIX: Remove run-requires 'perl(constant)' from the main package perl-Tickit, because it is found by generators. Please correct 'FIX' item. Otherwise the package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2126348 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
