[Bug 2120130] Review Request: python-gbinder - python bindings for libgbinder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2120130

Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |jkadlcik@xxxxxxxxxx



--- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
Hello Alessandro,
thank you for the package.

Overall it looks very good.


> SRPM URL: https://pagure.io/waydroid/python-gbinder

We have a tool called `fedora-review` which parses a Bugzilla ticket,
downloads the package, and performs some checks on it. Because of this,
the URL needs to be a direct link for downloading the SRPM file. 


> Here's a copr build of the srpm
> https://download.copr.fedorainfracloud.org/results/aleasto/waydroid/fedora-rawhide-x86_64/04620379-python-gbinder/python-gbinder-1.1.0-2.fc37.src.rpm 

Exactly like this :-)
Unfortunately, the link returns 404 now. When you rebuild a package in
Copr, or build its newer version, the old package is automatically
removed after some time. If you have a pending review in Bugzilla, it
is a good idea to always update the SRPM and spec URLs when you
rebuild the package in Copr.


> %global _description \
> Cython extension module for gbinder

Can you please change the description into 2-3 full sentences? Looking
at the package as an outsider, I have no idea what gbinder is, and
what this extension module allows me to do.


> python-gbinder.src: E: no-changelogname-tag

You don't have a %changelog section in your spec file, please take a
look here
https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs


> [ ]: %check is present and all tests pass.

Looking at the source code, there is a tests directory present. If it
makes sense, can you please add a %check section to your spec file
and run the tests there?
https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_GNU_Hello/#_running_tests


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2120130
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux