[Bug 2136235] Review Request: mingw-python-build - MinGW Python build library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2136235



--- Comment #16 from Sandro Mani <manisandro@xxxxxxxxx> ---
Spec URL: https://smani.fedorapeople.org/review/mingw-python-build.spec
SRPM URL:
https://smani.fedorapeople.org/review/mingw-python-build-0.8.0-3.fc38.src.rpm

%changelog
* Sun Oct 30 2022 Sandro Mani <manisandro@xxxxxxxxx> - 0.8.0-3
- Require rpm for %%{_rpmconfigdir}/macros.d/



> - Package contains BR: python2-devel or python3-devel
> => Not sure if there should be a BR: python3-devel since we are talking mingw here and the package builds fine without it

No this does not apply to mingw-python packages

> - Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib/rpm,
>      /usr/lib/rpm/macros.d
> => Looks like a missing requires on rpm (or whatever else is able to provide the directories you are installing to)

Fixed

> - README.md is missing in %files
> => tarball provides README.md. Please include it as %doc

Docs omitted per [1].

[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/MinGW/#_files_which_are_already_part_of_native_packages


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2136235
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux