https://bugzilla.redhat.com/show_bug.cgi?id=2129303 --- Comment #12 from Sergey <sergey@xxxxxxxxxxxx> --- (In reply to Benson Muite from comment #11) Benson, > Further comments: > a) The license file is included in both cbang and cbang-devel packages, > putting it in the cbang package alone is likely sufficient as cbang-devel > will require cbang. I'll take this to account. > b) What libraries are needed when using cbang? The spec file should likely > have a "Requires" section. The [0] in the Q&A Section under "Do I need a Requires: glibc..." states, that all binaries in a package are scanned for actual dependencies and the RPM automatically includes all necessary `Requires:`. Indeed, if you inspect the resulting arch-ed rpm you'll see that it requires for example, libboost_filesystem.so.1.76.0 and libboost_iostreams.so.1.76.0, the only parts from the `boost` library the cbang depends. > c) Is the folder cbang-devel-1.7.2-1.fc38.x86_64.rpm/usr/lib/cbang/config > has a number of config files. Are all of these needed? If so, should they be > in %libexecdir ? See > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_libexecdir > Perhaps they should be marked as configuration files, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_configuration_files These files are not configuration files, the name of a directory a bit misleading. Apart from C++ functions the cbang library contains a collection of a `scons` extensions scripts that could be used by a user to extend the build system of his project. Particularly, the camotics' (a project from which I unbundled cbang library per your request) build scripts uses part of these extensions directly form the cbang source tree. The directory structure created by the upstream developer has a subdir `config` with these scripts and the `camotic's` build script relies on the name `config` of this directory. These files are only needed during build of a dependant project so they are part of cbang-devel package. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Thank you, Sergey -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2129303 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
