https://bugzilla.redhat.com/show_bug.cgi?id=2129303 --- Comment #11 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Further comments: a) The license file is included in both cbang and cbang-devel packages, putting it in the cbang package alone is likely sufficient as cbang-devel will require cbang. b) What libraries are needed when using cbang? The spec file should likely have a "Requires" section. c) Is the folder cbang-devel-1.7.2-1.fc38.x86_64.rpm/usr/lib/cbang/config has a number of config files. Are all of these needed? If so, should they be in %libexecdir ? See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_libexecdir Perhaps they should be marked as configuration files, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2129303 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
