https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #10 from Stansoft <rpm@xxxxxxxxxxxx> --- (In reply to Benson Muite from comment #9) > Main issues are that: > a) header files should be in a -devel package I have added a -devel package > b) check the licenses, and add a license breakdown in the spec file. Done > c) It does not build on aarch64 Added ExclusiveArch: i686 x86_64 > https://copr.fedorainfracloud.org/coprs/fed500/aubit4gl-review/build/4946383/ > d) Add a check section with tests Done > e) Do you need doxygen as a build dependency to create man pages? I'm not sure, I did not get any errors building with mock regarding this. > f) The spec file has BuildRequires, but no Requires which are packages > needed for using the libraries libpq and ncurses is needed, but even without the Requires it is requiring them. > g) Check that there are no other bundled libraries > None that I am aware of, did you find some? Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-36-x86_64/04952430-aubit4gl/aubit4gl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/aubit4gl/fedora-36-x86_64/04952430-aubit4gl/aubit4gl-20220730.r12784-1.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
