https://bugzilla.redhat.com/show_bug.cgi?id=2119494 --- Comment #9 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Main issues are that: a) header files should be in a -devel package b) check the licenses, and add a license breakdown in the spec file. c) It does not build on aarch64 https://copr.fedorainfracloud.org/coprs/fed500/aubit4gl-review/build/4946383/ d) Add a check section with tests e) Do you need doxygen as a build dependency to create man pages? f) The spec file has BuildRequires, but no Requires which are packages needed for using the libraries g) Check that there are no other bundled libraries For a library versioning example see: https://download.copr.fedorainfracloud.org/results/snmende/cbang/fedora-rawhide-x86_64/04939140-cbang/cbang.spec https://bugzilla.redhat.com/show_bug.cgi?id=2129303 ideally, this would be best done upstream though. Some of the license used: *No copyright* [generated file] -------------------------------- aubit4gl-20220730.r12784/compilers/4glc/wantkw_gen.pl aubit4gl-20220730.r12784/lib/librpc/sun_rpc/a4gl_lib_rpc_xdr_int.h aubit4gl-20220730.r12784/tools/configuration/mk_config aubit4gl-20220730.r12784/tools/no_perl/wantkw.c aubit4gl-20220730.r12784/tools/no_perl/wantkw.h *No copyright* GNU General Public License ----------------------------------------- aubit4gl-20220730.r12784/tools/cygwin/readme-runtime.html *No copyright* GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)] ---------------------------------------------------------------------------------------------------- aubit4gl-20220730.r12784/incl/a4gl.mk aubit4gl-20220730.r12784/incl/footer.mki aubit4gl-20220730.r12784/incl/footer2.mki aubit4gl-20220730.r12784/incl/header.mki aubit4gl-20220730.r12784/lib/extra_libs/channel/channel.4gl aubit4gl-20220730.r12784/lib/extra_libs/file/libfile.4gl aubit4gl-20220730.r12784/lib/extra_libs/file_curl/libfile.4gl aubit4gl-20220730.r12784/tools/cygwin/run.exe *No copyright* MIT (old) ------------------------ aubit4gl-20220730.r12784/tools/cgi_4gl/cgi_4gla/WEB_PAGE.TXT *No copyright* Public domain ---------------------------- aubit4gl-20220730.r12784/lib/extra_libs/memcached/crc32_table.h aubit4gl-20220730.r12784/tools/fgldoc/aclocal.m4 aubit4gl-20220730.r12784/tools/misql/misql.4gl BSD 3-Clause License -------------------- aubit4gl-20220730.r12784/lib/bin/svn2cl.xsl aubit4gl-20220730.r12784/lib/libaubit4gl/curl.c FSF Unlimited License --------------------- aubit4gl-20220730.r12784/tools/fgldoc/configure FSF Unlimited License (with License Retention) ---------------------------------------------- aubit4gl-20220730.r12784/acinclude.m4 aubit4gl-20220730.r12784/aclocal.m4 aubit4gl-20220730.r12784/libltdl/aclocal.m4 FSF Unlimited License [generated file] -------------------------------------- aubit4gl-20220730.r12784/configure aubit4gl-20220730.r12784/libltdl/configure GNU General Public License -------------------------- aubit4gl-20220730.r12784/compilers/ace/dump_4gl.c aubit4gl-20220730.r12784/lib/extra_libs/mantisconnect/pregen/soapC.c aubit4gl-20220730.r12784/lib/extra_libs/mantisconnect/pregen/soapClient.c aubit4gl-20220730.r12784/lib/extra_libs/mantisconnect/pregen/soapH.h aubit4gl-20220730.r12784/lib/extra_libs/mantisconnect/pregen/soapStub.h GNU General Public License v2.0 or later ---------------------------------------- aubit4gl-20220730.r12784/etc/config/ltmain.sh aubit4gl-20220730.r12784/etc/config/missing aubit4gl-20220730.r12784/libltdl/acinclude.m4 aubit4gl-20220730.r12784/tools/fgldoc/fgldoc.1 aubit4gl-20220730.r12784/tools/fgldoc/fgldoc.c aubit4gl-20220730.r12784/tools/fgldoc/fgldoc.h aubit4gl-20220730.r12784/tools/fgldoc/lexer.l aubit4gl-20220730.r12784/tools/fgldoc/parser.y aubit4gl-20220730.r12784/tools/fgldoc/read_pdbs.ec aubit4gl-20220730.r12784/tools/gwd/Open_err.bsh aubit4gl-20220730.r12784/tools/project/shtool GNU General Public License v2.0 or later [generated file] --------------------------------------------------------- aubit4gl-20220730.r12784/etc/config/config.guess aubit4gl-20220730.r12784/etc/config/config.sub GNU General Public License v2.0 or later [obsolete FSF postal address (Temple Place)] ------------------------------------------------------------------------------------- aubit4gl-20220730.r12784/lib/libui/ui_xml/uilib/xml/skel GNU General Public License v3.0 or later ---------------------------------------- aubit4gl-20220730.r12784/tools/adbload2/adbload2_parse_pregen.tab.c aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/4glc/rules/generated/y.tab.c aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/4glc/rules/generated/y.tab.h aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/ace/y.tab.c aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/fcompile/y.tab.c aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/menus/y.tab.c aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/sql/y.tab.c aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/sql/y.tab.h aubit4gl-20220730.r12784/tools/no_yacc/cygwin/compilers/xgen/y.tab.c GNU General Public License, Version 2 ------------------------------------- aubit4gl-20220730.r12784/docs/COPYING aubit4gl-20220730.r12784/tools/4gl_beautify/dbbeauty/COPYING GNU General Public License, Version 2 [obsolete FSF postal address (Mass Ave)] ------------------------------------------------------------------------------ aubit4gl-20220730.r12784/tools/4gl_beautify/dbbeauty/dbbeauty.c aubit4gl-20220730.r12784/tools/4gl_beautify/dbbeauty/keyword.h GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)] -------------------------------------------------------------------------------------------- aubit4gl-20220730.r12784/tools/getopt/getopt.c aubit4gl-20220730.r12784/tools/getopt/getopt.h aubit4gl-20220730.r12784/tools/getopt/getopt1.c aubit4gl-20220730.r12784/tools/search.h GNU Lesser General Public License, Version 2.1 ---------------------------------------------- aubit4gl-20220730.r12784/libltdl/COPYING.LIB GNU Library General Public License v2 or later [obsolete FSF postal address (Mass Ave)] --------------------------------------------------------------------------------------- aubit4gl-20220730.r12784/tools/odbctest/incl/sql.h aubit4gl-20220730.r12784/tools/odbctest/incl/sqlext.h aubit4gl-20220730.r12784/tools/odbctest/incl/sqltypes.h aubit4gl-20220730.r12784/tools/odbctest/odbctest.c GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)] ------------------------------------------------------------------------------------------- aubit4gl-20220730.r12784/libltdl/ltdl.c aubit4gl-20220730.r12784/libltdl/ltdl.h Historical Permission Notice and Disclaimer - sell variant [generated file] --------------------------------------------------------------------------- aubit4gl-20220730.r12784/etc/config/install-sh aubit4gl-20220730.r12784/tools/fgldoc/install-sh LGPL (v2.1 or v3.0) ------------------- aubit4gl-20220730.r12784/lib/libui/ui_json/libjson.c aubit4gl-20220730.r12784/lib/libui/ui_json/libjson.h aubit4gl-20220730.r12784/lib/libui/ui_json/uilib/json.h aubit4gl-20220730.r12784/lib/libui/ui_xml/libjson.c aubit4gl-20220730.r12784/lib/libui/ui_xml/libjson.h MIT (old) --------- aubit4gl-20220730.r12784/tools/cgi_4gl/cgi_4gla/4gl_wrapper.c aubit4gl-20220730.r12784/tools/cgi_4gl/cgi_4gla/formsproc.c aubit4gl-20220730.r12784/tools/cgi_4gl/cgi_4gla/formsproc.h aubit4gl-20220730.r12784/tools/cgi_4gl/cgi_4glb/formsproc.c MIT License ----------- aubit4gl-20220730.r12784/incl/json.h aubit4gl-20220730.r12784/lib/libaubit4gl/json.c MIT License BSD 3-Clause License -------------------------------- aubit4gl-20220730.r12784/lib/extra_libs/memcached/memcache.h NTP License ----------- aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/README aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/m_apm.h aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/m_apm_lc.h aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_add.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_div.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_fft.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_flr.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_fpf.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_mul.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_rcp.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_rnd.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapm_set.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmcnst.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmfmul.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmgues.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmistr.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmstck.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmutil.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmutl1.c aubit4gl-20220730.r12784/lib/libaubit4gl/mapm/mapmutl2.c Public domain ------------- aubit4gl-20220730.r12784/lib/libaubit4gl/md5.c aubit4gl-20220730.r12784/lib/libaubit4gl/md5.h Public domain MIT License ------------------------- aubit4gl-20220730.r12784/lib/extra_libs/memcached/memcache.c SSLeay ------ aubit4gl-20220730.r12784/docs/LICENSE -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119494 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
