[Bug 2056243] Review Request: maui-mauikit-accounts - MauiKit utilities to handle User Accounts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2056243

Troy Dawson <tdawson@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tdawson@xxxxxxxxxx



--- Comment #2 from Troy Dawson <tdawson@xxxxxxxxxx> ---
- After discussion on KDE-SIG, this is being renamed to mauikit-accounts, so
the spec file has the correct name, it's the source rpm that has the wrong
name.
As was also discussed, the name change can happen when the package is
requested.

- The latest version is also version 2.0.0.  Updating to that needs to be in
concert with mauikit and mauikit-filebrowsing.

- This also uses %define instead of %global.  Is there a reason for this?

- The final problem is a hidden license file.

I think the following, added to your %prep section will fix the problem.

  mv src/controls/qmldir.license LICENSES/


At the very least, fix that license issue and I'll approve this.  But if you
could fix the others while you are at it that would be great.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2056243
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux