https://bugzilla.redhat.com/show_bug.cgi?id=2127168 --- Comment #6 from Zamir SUN <sztsian@xxxxxxxxx> --- (In reply to Petr Menšík from comment #5) > A new package would become part of rawhide, upcoming Fedora 38. That has > proposed change [1] to use SPDX license identifiers. For Fedora 37 'LGPLv2+' > would be okay, but for rawhide, where those reviews targets, it should be > 'LGPL-2.1-or-later' IMO. But this might be changed later. Why I haven't > already passed the review are remaining unowned directories. > Oh I haven't check the change yet. Thanks for the info. > I think you have fixed just dbus-1 directories, but some portal directories > remain unowned. It should own just directory by this in %files: > > %dir %{_datadir}/xdg-desktop-portal > %dir %{_datadir}/xdg-desktop-portal/portals > > Unless it solves it by another Requires as well. Would it make sense if it > also required xdg-desktop-portal package owning those directories? Can the > package do something useful without this package installed? > > rpm -qf /usr/share/xdg-desktop-portal or rpm -qf > /usr/share/xdg-desktop-portal/portals must report owning package when the > package is installed. If it creates it, it either has to own it or depend on > package owning it. Take as example podman fedora container, where this > package can be installed too. After it were installed and uninstalled, all > directories it has created should be deleted again. > Ahhh my fault. I thought I already have xdg-desktop-portal as dependency so I was thinking the two directory you mentioned is fine. Here is the fixed one https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/04919428-xdg-desktop-portal-lxqt/fedora-review/review.txt SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/04919428-xdg-desktop-portal-lxqt/xdg-desktop-portal-lxqt.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/review-lxqt/fedora-rawhide-x86_64/04919428-xdg-desktop-portal-lxqt/xdg-desktop-portal-lxqt-0.2.0-1.fc38.src.rpm > 1. https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1#Summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2127168 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
