https://bugzilla.redhat.com/show_bug.cgi?id=2127168 --- Comment #5 from Petr Menšík <pemensik@xxxxxxxxxx> --- A new package would become part of rawhide, upcoming Fedora 38. That has proposed change [1] to use SPDX license identifiers. For Fedora 37 'LGPLv2+' would be okay, but for rawhide, where those reviews targets, it should be 'LGPL-2.1-or-later' IMO. But this might be changed later. Why I haven't already passed the review are remaining unowned directories. I think you have fixed just dbus-1 directories, but some portal directories remain unowned. It should own just directory by this in %files: %dir %{_datadir}/xdg-desktop-portal %dir %{_datadir}/xdg-desktop-portal/portals Unless it solves it by another Requires as well. Would it make sense if it also required xdg-desktop-portal package owning those directories? Can the package do something useful without this package installed? rpm -qf /usr/share/xdg-desktop-portal or rpm -qf /usr/share/xdg-desktop-portal/portals must report owning package when the package is installed. If it creates it, it either has to own it or depend on package owning it. Take as example podman fedora container, where this package can be installed too. After it were installed and uninstalled, all directories it has created should be deleted again. 1. https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1#Summary -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2127168 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
