https://bugzilla.redhat.com/show_bug.cgi?id=2133114 --- Comment #5 from Davide Cavalca <dcavalca@xxxxxx> --- > a) Opencryptoki is available as a package https://packages.fedoraproject.org/pkgs/opencryptoki/opencryptoki/ can tests be run against this during the build? Per the project README, the tests aren't necessarily safe to run as they are, as they'll destroy any token attached to the host, so I figured leaving them out was best. I also couldn't get this to build properly against opencryptoki due to a mismatch in types for some data structures. > b) Fedora abbreviation for Apache 2.0 is ASL 2.0 https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ That's the old abbreviation, the current policy is to use the SPDX one instead: https://docs.fedoraproject.org/en-US/legal/license-field/ > c) The headers are available at https://docs.oasis-open.org/pkcs11/pkcs11-base/v2.40/pkcs11-base-v2.40.html maybe they should be a separate development package? I looked into this. Unfortunately there are multiple incompatible versions of these headers, and every project seems to bundle the one they use, making maintaining a unified system version difficult. For the time being, I think keeping these bundled is the best solution. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2133114 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
