https://bugzilla.redhat.com/show_bug.cgi?id=1822847 --- Comment #14 from Akira TAGOH <tagoh@xxxxxxxxxx> --- (In reply to Benson Muite from comment #13) > c) Consider naming the metapackage vl-gothic-fonts-all > https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ > #_assembling_different_family_font_packages_font_metapackages I don't get it. what are you proposing? > d) Example multipackage spec files: > https://src.fedoraproject.org/rpms/khmer-os-fonts/blob/rawhide/f/khmer-os- > fonts.spec > https://src.fedoraproject.org/rpms/culmus-fonts/blob/rawhide/f/culmus-fonts. > spec > https://src.fedoraproject.org/rpms/julietaula-montserrat-fonts/blob/rawhide/ > f/julietaula-montserrat-fonts.spec same. > e) Without the metapackage, there are no installation errors. With the > metapackage, there is an installation > error because the dependencies of the metapackage cannot be found. What's the real error? it works for me though. please add the full logs if you found any issues. > e) Possible updates to spec file (probably still want to include > metapackage): > %global fontpkgname1 %{foundry}-gothic-regular-fonts Why did you add "regular" in the package name? it is a style. not a part of the family name. it is not a case for vl-gothic-fonts, but, if a font has non-regular style fonts such as italic, are you going to sub-package it separately? No, the intention here is to get same families installed together and provide all variants in one package for better experience. that isn't what our packaging guidelines says. Only updated source URL. Spec URL: https://tagoh.fedorapeople.org/reviews/vl-gothic-fonts/vl-gothic-fonts.spec SRPM URL: https://tagoh.fedorapeople.org/reviews/vl-gothic-fonts/vl-gothic-fonts-20220612-2.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1822847 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
