https://bugzilla.redhat.com/show_bug.cgi?id=1822847 --- Comment #13 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- fedora-review seems to run for me now. Initial comments: a) Can the sources be downloaded from https://mirrors.gigenet.com/OSDN//vlgothic/77450/VLGothic-% b) When running fedora-review, I get the following output "INFO: Install command returned error code 30", the reason for this is unclear, but seems to be an error related to installation https://github.com/rpm-software-management/mock/blob/main/mock/py/mockbuild/exception.py#L38 c) Consider naming the metapackage vl-gothic-fonts-all https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/#_assembling_different_family_font_packages_font_metapackages d) Example multipackage spec files: https://src.fedoraproject.org/rpms/khmer-os-fonts/blob/rawhide/f/khmer-os-fonts.spec https://src.fedoraproject.org/rpms/culmus-fonts/blob/rawhide/f/culmus-fonts.spec https://src.fedoraproject.org/rpms/julietaula-montserrat-fonts/blob/rawhide/f/julietaula-montserrat-fonts.spec e) Without the metapackage, there are no installation errors. With the metapackage, there is an installation error because the dependencies of the metapackage cannot be found. e) Possible updates to spec file (probably still want to include metapackage): BuildArch: noarch Version: 20220612 Release: 1%{?dist} License: mplus and BSD URL: http://dicey.org/vlgothic %global foundry vl %global fontlicenses LICENSE_J.mplus LICENSE_E.mplus LICENSE LICENSE.en %global fontdocs README README_J.mplus README.sazanami README_E.mplus %global fontdocsex %{fontlicenses} %global common_description %{expand: VLGothic provides Japanese TrueType fonts from the Vine Linux project. Most of the glyphs are taken from the M+ and Sazanami Gothic fonts, but some have also been improved by the project. } %global fontfamily1 VL Gothic %global fontsummary1 Japanese TrueType font %global fontpkgheader1 %{expand: Obsoletes: vlgothic-fonts < %{version}-%{release} Provides: vl-gothic-regular-fonts = %{version}-%{release} } %global fontpkgname1 %{foundry}-gothic-regular-fonts %global fonts1 VL-Gothic-Regular.ttf %global fontconfs1 %{SOURCE11} %global fontdescription1 %{expand: %{common_description} This package provides the monospace VLGothic font. } %global fontfamily2 VL PGothic %global fontsummary2 Proportional Japanese TrueType font %global fontpkgheader2 %{expand: Obsoletes: vlgothic-p-fonts < %{version}-%{release} Provides: vl-pgothic-regular-fonts = %{version}-%{release} } %global fontpkgname2 %{foundry}-pgothic-regular-fonts %global fonts2 VL-PGothic-Regular.ttf %global fontconfs2 %{SOURCE12} %global fontdescription2 %{expand: %{common_description} This package provides the VLGothic font with proportional glyphs for some non-Japanese characters. } Source0: https://mirrors.gigenet.com/OSDN//vlgothic/77450/VLGothic-%{version}.tar.xz Source11: 65-3-vl-gothic-regular-fonts.conf Source12: 65-2-vl-pgothic-regular-fonts.conf Name: vl-gothic-fonts Summary: Japanese TrueType fonts %description %wordwrap -v common_description %fontpkg -a %prep %autosetup -n VLGothic iconv -f EUC-JP -t UTF-8 -o README.sazanami.tmp README.sazanami rm README.sazanami mv README.sazanami.tmp README.sazanami %build %fontbuild -a %install %fontinstall -a %check %fontcheck -a %fontfiles -a %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1822847 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
