https://bugzilla.redhat.com/show_bug.cgi?id=2082886 Otto Liljalaakso <otto.liljalaakso@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(thofmann@fedorapr | |oject.org) --- Comment #2 from Otto Liljalaakso <otto.liljalaakso@xxxxxx> --- Could you build this again for current Rawhide? I get an error when I try 'fedpkg mockbuild': + /usr/bin/python3 -m tox --current-env -q --recreate -e py311 .S..Traceback (most recent call last): File "/builddir/build/BUILDROOT/python-nagios-plugins-check_systemd-2.3.1-2.fc38.x86_64//usr/lib64/nagios/plugins/check_systemd", line 5, in <module> from check_systemd import main ModuleNotFoundError: No module named 'check_systemd' F..................................... ====================================================================== FAIL: test_entry_point (test_subprocess.TestCli.test_entry_point) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/check_systemd-2.3.1/test/test_subprocess.py", line 288, in test_entry_point self.assertEqual(process.returncode, 0) AssertionError: 1 != 0 ---------------------------------------------------------------------- Ran 42 tests in 2.614s FAILED (SKIP=1, failures=1) ERROR: InvocationError for command /usr/bin/nosetests --nocapture (exited with code 1) ___________________________________ summary ____________________________________ ERROR: py311: commands failed Since an importable module is involved, should you be using %pyproject_save_files in the specfile? Other than that, two comments from reading the specfile: > License: LGPLv2+ Since recently, new packages must use SPDX license identifiers. Thus, this should be "LGPL-2.1-or-later". Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names Additionally, where did you get the "+"? Looking at the repo, it looks like the license is "LGPL-2.1-only". > Summary: Nagios plugin to check systemd Would it make sense to use %{summary} here? You are already doing a similar thing for descriptions. (This comment is not review blocking.) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2082886 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
