https://bugzilla.redhat.com/show_bug.cgi?id=2087143 --- Comment #5 from fedepell <fede@xxxxxxxxxxxx> --- Hello Jakub, Thanks again for the review! (In reply to Jakub Kadlčík from comment #4) > I downloaded and extracted the new SRPM and I can't see any link in > the patch. Maybe you somehow built the new SRPM using the old patch? > > Anyhow, I think it is a better idea to put the link into the spec file > itself. Simply, like this: > > # https://github.com/robotframework/robotframework/pull/123456 > Patch0: 0001-Patch_tests_with_Python_3_11.patch Apologies, that was my stupid mistake where I was testing the RPM. The patch file is now fixed, but added also in the spec the reference to the issue to make it easier! > > python3-robotframework.noarch: W: no-manual-page-for-binary libdoc > > python3-robotframework.noarch: W: no-manual-page-for-binary rebot > > python3-robotframework.noarch: W: no-manual-page-for-binary robot > It would be nice to have manpages for these programs but I won't block > the package review because of it. Just keep in mind, that you can ask > the upstream, and eventually add them in the future. I double checked if I forgot them, but indeed there are not there. Indeed man pages would be handy, but my impression is that it's not often the norm to have them with Python programs/packages (ie. I've given a brief look to a bunch of well known Python packages which have as well a program invocation, but most of them lack a man page indeed (just to give some names: pytest, spyder, shiboken2, pylint). I can try to give a look and see what could they think upstream :) > > %{_bindir}/{robot,rebot,libdoc} > I think we don't need to install the libdoc script? From what I > understand, it is for generating documentation. Or is it used by the > end users? I would say it is useful to give, since if the end user writes a Robot Framework library or resource file (which may very likely is the case if the user is preparing a slightly complicated test suite), then the user can use libdoc then to convert to HTML or other output to "document" the written test suite. Likely could be viewed as a useful add-on, but maybe not worth to have it split from remainder of Robot Framework? > > MIT License > > ----------- > > robotframework-5.0.1/src/robot/htmldata/lib/jquery.highlight.min.js > > robotframework-5.0.1/src/robot/htmldata/lib/jquery.tmpl.min.js > > robotframework-5.0.1/utest/webcontent/jasmine-1.0.2/MIT.LICENSE > Except for ASL 2.0, I also found these two licenses. I am not > familiar with the upstream project, so it's up to you - Do we even > want these files installed? Are they for the program itself or just > some kind of documentation? If we want them, I think we need to update I've checked in detail, and those are in the source file just if the HTML Documentation is done (the first two, as then the generated documentation uses jquery) and for unit testing (last one). These are then not delivered in the RPM, the documentation is right now delivered only as RST (which for some parts just references the HTML on the package web site). If we keep it like this (so doc delivered just as RST, leaving the whole "manual" for online usage) my understanding is that therefore we wouldn't need to change the licensing and take care of the bundling. Does this sound correct? Or even if it is just part of the original source package (in which case indeed I have to add MIT)? Of course the question may be: should we better deliver also the full HTML docs? I've given a look at a series of other Python packages (like the ones mentioned before) and saw a mixed usage: some just with RST, some HTML converted (which usually bring jquery or the like). Most of them are in the first category. What do you think? > > python3-robotframework.noarch: W: invalid-license ASL 2.0 > I think that it is now required to use the SPDX license names. So > instead of ASL 2.0 it would be Apache-2.0 Fixed that, thanks! New links: Spec file as before: https://github.com/fedepell/rpms-specs/blob/master/python/robotframework/python-robotframework.spec SRPM: https://github.com/fedepell/rpms-specs/raw/master/python/robotframework/python-robotframework-5.0.1-5.fc36.src.rpm Many thanks again! Federico -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087143 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
