https://bugzilla.redhat.com/show_bug.cgi?id=2087143 --- Comment #4 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Thank you for the changes, > I've added this information inside the patch itself (so short > description and link). I downloaded and extracted the new SRPM and I can't see any link in the patch. Maybe you somehow built the new SRPM using the old patch? Anyhow, I think it is a better idea to put the link into the spec file itself. Simply, like this: # https://github.com/robotframework/robotframework/pull/123456 Patch0: 0001-Patch_tests_with_Python_3_11.patch > python3-robotframework.noarch: W: no-manual-page-for-binary libdoc > python3-robotframework.noarch: W: no-manual-page-for-binary rebot > python3-robotframework.noarch: W: no-manual-page-for-binary robot It would be nice to have manpages for these programs but I won't block the package review because of it. Just keep in mind, that you can ask the upstream, and eventually add them in the future. > %{_bindir}/{robot,rebot,libdoc} I think we don't need to install the libdoc script? From what I understand, it is for generating documentation. Or is it used by the end users? > *No copyright* MIT License > -------------------------- > robotframework-5.0.1/src/robot/htmldata/rebot/log.css > > MIT License > ----------- > robotframework-5.0.1/src/robot/htmldata/lib/jquery.highlight.min.js > robotframework-5.0.1/src/robot/htmldata/lib/jquery.tmpl.min.js > robotframework-5.0.1/utest/webcontent/jasmine-1.0.2/MIT.LICENSE Except for ASL 2.0, I also found these two licenses. I am not familiar with the upstream project, so it's up to you - Do we even want these files installed? Are they for the program itself or just some kind of documentation? If we want them, I think we need to update the License field, to ASL 2.0 AND MIT. Also, since jquery is bundled library, I think we need to add something like this (replace 123 with the actual jquery version that is found in the code). Provides: bundled(jquery) = 123 And it will need to be done for all the libraries in htmldata/lib/ directory. Please see bundling guidelines https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > python3-robotframework.noarch: W: invalid-license ASL 2.0 I think that it is now required to use the SPDX license names. So instead of ASL 2.0 it would be Apache-2.0 When you go to the allowed licenses list https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ you can search for ASL 2.0 and the row contains the SPDX name. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087143 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
