https://bugzilla.redhat.com/show_bug.cgi?id=2087143 --- Comment #3 from fedepell <fede@xxxxxxxxxxxx> --- Hello Jakub, Many thanks for reviewing the proposed package! (In reply to Jakub Kadlčík from comment #2) > > Spec URL stays the same: ... > > SRPM URL for FC35: ... > The links need to point directly to the raw file or file download. In the > case > of the spec, you want to go to the link you posted, click the "Raw" button, > and > use that URL. For the SRPM, you want to "Copy link address" for the > "Download" > button and use that. Ok, clear! Updated links (after applying the proposed changes): Spec file URL: https://raw.githubusercontent.com/fedepell/rpms-specs/master/python/robotframework/python-robotframework.spec SRPM URL for FC36: https://github.com/fedepell/rpms-specs/raw/master/python/robotframework/python-robotframework-5.0.1-4.fc36.src.rpm > > Patch0: 0001-Patch_tests_with_Python_3_11.patch > Is there any upstream pull request with this patch? If yes, can you > please add a link here as a comment above the patch? Otherwise, can > you please submit the PR? Yes, correct it is a patch from upstream. I've added this information inside the patch itself (so short description and link). Most likely indeed (noted also in the patch) it can be removed with next upstream release. > > %global _description %{expand: > According to the packaging guidelines > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_summary_and_description > the description lines should be no longer than 80 characters. Can you > please re-wrap them? Done! > > %{_bindir}/* > Can you please be more specific, instead of using wildcard here? Done, adding explicitly the three needed files. Hope it looks in better shape now! :) I've also rerun it via copr: https://copr.fedorainfracloud.org/coprs/fedepell/Miscrpms/build/4876539/ Thanks again for the review! Federico -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087143 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
