https://bugzilla.redhat.com/show_bug.cgi?id=2128851 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Benson Muite from comment #2) > Comments: > a) add "make check_java" and "make check_python" to the spec file. Done. > b) should there be an obsoletes section in the spec for > python-snowball-stemmer and libstemmer? No, because the package names have not changed. They will be built from a different dist-git repository, yes, but rpm/dnf/... don't care about that. They just compare package names, and we are keeping the libstemmer and python3-snowball-stemmer names. (In reply to Julien Enselme from comment #3) > I think that we should add obsoletes section for python-snowball-stemmer and > libstemmer since this package is aimed at replacing them. This excepted, > nothing to add to the review of Benson. Same comment as above. Obsoletes are for package name changes, which isn't happening here. New URLs: Spec URL: https://jjames.fedorapeople.org/snowball/snowball.spec SRPM URL: https://jjames.fedorapeople.org/snowball/snowball-2.2.0-4.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2128851 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
