[Bug 2123954] Review Request: python-PyMunin3 - Python module for developing Munin Multigraph Plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2123954



--- Comment #15 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) I am not familiar with rpmautospec. Last time I tried to look into it, I
found it frustrating to use it. Hence I am not willing to move my packages to
use it till Fedora mandates it in future someday.

2) I will always prefer to see the submitted SPEC file, also included in the
SRPM file. Here your SPEC is updated but not SRPM. Remember if it was reverse I
would have not minded much but in the end we import SRPM when we initially add
new package in Fedora.

3) Like I said I am not much aware of rpmautospec usage. I pick your SPEC that
uses auto macros, build SRPM on my machine and ran a build (that uses auto
macros) first time in my copr repo. I am happy that it worked fine.
https://copr.fedorainfracloud.org/coprs/pnemade/misc/build/4843654/

So why you want different SPEC file in SRPM? Or did I used your SPEC wrongly?
Please check and tell me.

if I need to give copr links then they will be 
SPEC URL:
https://download.copr.fedorainfracloud.org/results/pnemade/misc/fedora-rawhide-x86_64/04843654-python-PyMunin3/python-PyMunin3.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/pnemade/misc/fedora-rawhide-x86_64/04843654-python-PyMunin3/python-PyMunin3-3.0.1-1.fc38.src.rpm

I also realized below thing.
During normal package review concept, packager need to keep bumping release tag
and add relevant changelog entry. But now with usage of rpmautospec macros I
need to think how package review should happen. Maybe I should stop asking
packager for changelog entry as there is actually no real git commits happening
till package gets approved. So in the end release tag looks remain "1"
irrespective of how many times SPEC gets updated.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2123954
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux