https://bugzilla.redhat.com/show_bug.cgi?id=2126943 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #13 from Petr Pisar <ppisar@xxxxxxxxxx> --- Thanks for polishing the package. Changes in the spec file: --- perl-Template-Plugin-CGI.spec.old 2022-09-15 19:42:47.000000000 +0200 +++ perl-Template-Plugin-CGI.spec 2022-09-16 14:02:03.000000000 +0200 @@ -1,7 +1,7 @@ Summary: Simple Template Toolkit plugin interfacing to the CGI module Name: perl-Template-Plugin-CGI Version: 3.101 -Release: 2%{?dist} +Release: 3%{?dist} License: (GPL-1.0-or-later OR Artistic-1.0-Perl) AND MIT URL: https://metacpan.org/release/Template-Plugin-CGI Source: https://cpan.metacpan.org/modules/by-module/Template/Template-Plugin-CGI-%{version}.tar.gz @@ -12,24 +12,21 @@ BuildRequires: perl(blib) BuildRequires: perl(CGI) >= 4.44 BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 +BuildRequires: perl(File::Spec) BuildRequires: perl-generators BuildRequires: perl-interpreter BuildRequires: perl(IO::Handle) BuildRequires: perl(IPC::Open3) BuildRequires: perl(lib) BuildRequires: perl(strict) +BuildRequires: perl(Template) >= 3.100 BuildRequires: perl(Template::Plugin) BuildRequires: perl(Template::Test) -BuildRequires: perl(Test2::Bundle::Extended) -BuildRequires: perl(Test2::Plugin::NoWarnings) -BuildRequires: perl(Test2::Suite) -BuildRequires: perl(Test2::Tools::Explain) -BuildRequires: perl(Test::Builder) -BuildRequires: perl(Test::CPAN::Meta) BuildRequires: perl(Test::More) BuildRequires: perl(warnings) -Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: perl(CGI) >= 4.44 +Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Conflicts: perl-Template-Toolkit < 3.010-5 %{?perl_default_filter} @@ -44,7 +41,7 @@ %build -%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 +perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 %make_build @@ -65,6 +62,9 @@ %changelog +* Fri Sep 16 2022 Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> - 3.101-3 +- Address comments from review process + * Thu Sep 15 2022 Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> - 3.101-2 - Address comments from review process $ rpmlint perl-Template-Plugin-CGI.spec ../SRPMS/perl-Template-Plugin-CGI-3.101-3.fc38.src.rpm ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-3.fc38.noarch.rpm ========================================================== rpmlint session starts ========================================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Template-Plugin-CGI.noarch: W: invalid-license GPL-1.0-or-later perl-Template-Plugin-CGI.noarch: W: invalid-license Artistic-1.0-Perl perl-Template-Plugin-CGI.src: W: invalid-license GPL-1.0-or-later perl-Template-Plugin-CGI.src: W: invalid-license Artistic-1.0-Perl =========================== 2 packages and 1 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.5 s ========================== rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-3.fc38.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(base) 1 perl(CGI) 1 perl(CGI) >= 4.44 1 perl(strict) 1 perl(Template::Plugin) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 TODO: You can remove the underspecified, and now redundant, dependency on unversioned 'perl(CGI)' with this line placed after %{?perl_default_filter} line: %global __requires_exclude %{?__requires_exclude:%{__requires_exclude}|}^perl\\(CGI\\)$ Removing underspecified dependencies helps to decrease a size of YUM repository metadata users needs to download on their systems. $ resolvedeps rawhide ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-3.fc38.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 38 (https://koji.fedoraproject.org/koji/taskinfo?taskID=92077799). Ok. Please consider correcting the TODO item before building this package. Resolution: Package APROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2126943 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
