https://bugzilla.redhat.com/show_bug.cgi?id=2126943 --- Comment #12 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- (In reply to Petr Pisar from comment #11) > Now reviewing the second release of the spec file. > > TODO: You can use a plain 'perl' command instead of macro '%{__perl}' > (perl-Template-Plugin-CGI.spec:32, perl-Template-Plugin-CGI.spec:47). Done. > > FIX: Build-require 'perl(File::Spec)' (t/00-compile.t:23). > FIX: Build-require 'perl(Template) >= 3.100' (t/cgi.t:21). > It seems you forgot to add dependencies for the tests. Done. > > TODO: Do not build-require perl(Test2::Bundle::Extended), > perl(Test2::Plugin::NoWarnings), perl(Test2::Suite), > perl(Test2::Tools::Explain), perl(Test::Builder). They are probably > copy-paste leftovers from separating the module by upstream. As I showed in > my previous comment, depending on them does not bring any benefit. It only > make a dependency tree of this packages larger and more prone to build > failures (if the dependent package breaks). This in an example where > upstream did a mistake. > Done. > FIX: Do not build-require perl(Test::CPAN::Meta). It's not used because a > test never reaching that place (t/author-distmeta.t:12). This is the same > case as for Test::NoTabs. Done. > > All tests pass. Ok. > > $ rpmlint perl-Template-Plugin-CGI.spec > ../SRPMS/perl-Template-Plugin-CGI-3.101-2.fc38.src.rpm > ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-2.fc38.noarch.rpm > ========================================================== rpmlint session > starts ========================================================= > rpmlint: 2.2.0 > configuration: > /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/licenses.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > checks: 32, packages: 3 > > perl-Template-Plugin-CGI.noarch: W: invalid-license GPL-1.0-or-later > perl-Template-Plugin-CGI.noarch: W: invalid-license Artistic-1.0-Perl > perl-Template-Plugin-CGI.src: W: invalid-license GPL-1.0-or-later > perl-Template-Plugin-CGI.src: W: invalid-license Artistic-1.0-Perl > =========================== 2 packages and 1 specfiles checked; 0 errors, 4 > warnings, 0 badness; has taken 0.5 s ========================== > rpmlint output is Ok. > > $ rpm -q -lv -p > ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-2.fc38.noarch.rpm > drwxr-xr-x 2 root root 0 Sep 16 11:13 > /usr/share/doc/perl-Template-Plugin-CGI > -rw-r--r-- 1 root root 703 Apr 27 18:27 > /usr/share/doc/perl-Template-Plugin-CGI/Changes > drwxr-xr-x 2 root root 0 Sep 16 11:13 > /usr/share/licenses/perl-Template-Plugin-CGI > -rw-r--r-- 1 root root 1069 Apr 27 18:27 > /usr/share/licenses/perl-Template-Plugin-CGI/LICENSE > -r--r--r-- 1 root root 2062 Sep 16 11:13 > /usr/share/man/man3/Template::Plugin::CGI.3pm.gz > drwxr-xr-x 2 root root 0 Sep 16 11:13 > /usr/share/perl5/vendor_perl/Template > drwxr-xr-x 2 root root 0 Sep 16 11:13 > /usr/share/perl5/vendor_perl/Template/Plugin > -r--r--r-- 1 root root 3549 Apr 27 18:27 > /usr/share/perl5/vendor_perl/Template/Plugin/CGI.pm > File layout and permissions are Ok. > > $ rpm -q --requires -p > ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-2.fc38.noarch.rpm | sort -f | > uniq -c > 1 perl(:MODULE_COMPAT_5.36.0) > 1 perl(base) > 1 perl(CGI) > 1 perl(strict) > 1 perl(Template::Plugin) > 1 perl(warnings) > 1 rpmlib(CompressedFileNames) <= 3.0.4-1 > 1 rpmlib(FileDigests) <= 4.6.0-1 > 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 > 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 > TODO: Constrain 'perl(CGI)' run-time dependency with '>= 4.44' version > (META.json:32). This can be done either by adding an explicit 'Requires: > perl(CGI) >= 4.44' line to the spec file or patching a source code to 'use > CGI 4.44;' at lib/Template/Plugin/CGI.pm:26. Done (in .spec file). > > $ rpm -q --provides -p > ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-2.fc38.noarch.rpm | sort -f | > uniq -c > 1 perl(Template::Plugin::CGI) = 3.101 > 1 perl-Template-Plugin-CGI = 3.101-2.fc38 > Binary provides are Ok. > > $ rpm -q --conflicts -p > ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-2.fc38.noarch.rpm | sort -f | > uniq -c > 1 perl-Template-Toolkit < 3.010-5 > Binary conflicts are Ok. > > $ resolvedeps rawhide > ../RPMS/noarch/perl-Template-Plugin-CGI-3.101-2.fc38.noarch.rpm > Binary dependencies are resolvable. Ok. > > The package builds in Fedora 38 > (https://koji.fedoraproject.org/koji/taskinfo?taskID=92071243). Ok. > > Otherwise, the package is in line with Fedora and Perl packaging guidelines. > Please correct the FIX items, consider correcting TODO items, and provide an > updates spec file. Yesterday, I contacted upstream w.r.t. to clarify licensing tag. Please find updated files: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/perl-Template-Plugin-CGI.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-Template-Plugin-CGI-3.101-3.fc38.src.rpm Fedora Review Log: https://download.copr.fedorainfracloud.org/results/dwrobel/perl-Template-Plugin-CGI/fedora-rawhide-x86_64/04840116-perl-Template-Plugin-CGI/fedora-review/review.txt Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=92076549 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2126943 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
