https://bugzilla.redhat.com/show_bug.cgi?id=2126943 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Your are completely right: If a Perl module requires CGI::Cookie, then an RPM package which delivers the module should require perl(CGI::Cookie). Not perl(CGI). However, in Template-Plugin-CGI-3.101 I cannot see anywhere e.g. CGI::Cookie to be mentioned. Neither "grep -Hnr CGI::Cookie" command shows it, neither "cpanspec Template-Plugin-CGI-3.101.tar.gz" generates it. I did not know scandeps.pl tool, but I think tool is broken or I cannot use it properly. First you want to run it with -R, otherwise it reports dependencies of dependencies. (Which is why your original spec file contains to much modules. RPM packages should not list transitive dependencies in general). Second you want to call it with -B, otherwise it hides core modules. Third it hides uninstalled direct dependencies, it probably only does dynamic analysis from %INC hash after loading the file or it does not account that current perl does not have ./ in @INC. Dynamic analysis is not bad, but we also need static analysis because Perl can load modules only in a specific code path (e.g. from a called subroutine.) See: $ scandeps.pl -V -B -R ./lib/Template/Plugin/CGI.pm # Could not find source file 'Template/Plugin/CGI.pm' in @INC or @IncludeLibs. Skipping it. # Could not find source file 'Template/Plugin.pm' in @INC or @IncludeLibs. Skipping it. # Could not find source file 'CGI.pm' in @INC or @IncludeLibs. Skipping it. # Template/Plugin/CGI.pm [] # base.pm [module] # strict.pm [module] # warnings.pm [module] # # Legend: [C]ore [X]ternal [S]ubmodule [?]NotOnCPAN 'base' => '0', # C? # Template::Plugin::CGI 'strict' => '0', # C? # Template::Plugin::CGI 'warnings' => '0', # C? # Template::Plugin::CGI It is missing Template::Plugin and CGI. For scanning sources for Perl dependencies I use tangerine tool (installed from a same-named RPM package). That's why I think the dependency I listed should not be there. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2126943 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
