https://bugzilla.redhat.com/show_bug.cgi?id=2126943 --- Comment #2 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- (In reply to Petr Pisar from comment #1) Thank you for taking the review and for your valuable comments. I'll fix the issues. > > FIX: Remove unused dependencies: perl(Carp), perl(CGI::Cookie), > Where did you get these dependencies from? I cannot see them used anywhere > in the code. > It's a sum (excluding duplicates) from the following two tools: $ scandeps.pl lib/Template/Plugin/CGI.pm $ cpanspec Template-Plugin-CGI-3.101.tar.gz I'm not an expert in perl, but I liked the output in the form of: perl(CGI::Cookie) perl(CGI::File::Temp) perl(CGI::Util) instead of using perl(CGI) alone just to avoid a situation which we have in bug#2124543#c3. My assumption is (maybe I'm wrong) that if at some point in time someone will decide to spin off or move e.g CGI:Util to a separate package then this would be transparent to me (it might still require to package CGI::Util, though). So, is it acceptable to use this "more granular" form of "Requires:" or I have to use just the top module name (in the above example perl(CGI))? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2126943 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
