[Bug 2123954] Review Request: python-PyMunin3 - Python module for developing Munin Multigraph Plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2123954



--- Comment #5 from Sandro <gui1ty@xxxxxxxxxxxxx> ---
Created attachment 1909951
  --> https://bugzilla.redhat.com/attachment.cgi?id=1909951&action=edit
original spec file

(In reply to Parag AN(पराग) from comment #4)
> (In reply to Sandro from comment #2)
> > > Issues:
> > > =======
> > > - Dist tag is present.
> > 
> > I've got no clue what that means.
> 
>   I think this is related to rpmautospec. No change is required then if you
> continue using %autorelease

I thought so, too, but wasn't sure.

> > > - You don't need below lines as you already have "BuildArch:      noarch"
> > >   # Package does not provide debug info
> > >   %global debug_package %{nil}
> > 
> > Hmm. Without it my local mock build fails with:
> >
> > error: Empty %files file /builddir/build/BUILD/PyMunin3-3.0.1/debugsourcefiles.list
> 
> Okay then you can keep it in spec file but I will be interested in finding
> why it is required?
> Only few Fedora python* packages needed to add "%global debug_package %{nil}"

Makes me feel like I hit the jackpot. ;)

> > > - local definition of using the updated rpmautospec macro is not needed now
> > > as I see python-rpmautospec-0.3.0 is already built for F35+ and EPEL9
> > > releases.
> > 
> > The spec file I linked is from Copr, which expands %{autorelease} and puts
> > that in the spec file. I can upload my original spec file if needed.
> > 
> 
> Can you upload original spec file?

I stapled it to this bug.

> > > python3-PyMunin3.noarch: W: invalid-license GPL-3.0
> > 
> > I changed it to "GPL-3.0-only" as per
> > https://docs.fedoraproject.org/en-US/legal/allowed-licenses/
> 
> Thanks

I like the fact that Copr is able to run fedora-review. Should have used that
on my initial release...


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2123954
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux