https://bugzilla.redhat.com/show_bug.cgi?id=2120002 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(loganjerry@gmail. | |com) | --- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Jonathan Wright from comment #5) > I don't think there's anything in packaging guidelines prohibiting > overriding some of the default flags. In fact, guidelines say it's > permissible. You are correct. It isn't forbidden, although the guidelines do say that changing the -O option is "discouraged". If you or upstream would like me to do so, I am happy to suggest patches for the warnings. In the meantime, this package meets all of the packaging guidelines, so it is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120002 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
