https://bugzilla.redhat.com/show_bug.cgi?id=2120002 Jonathan Wright <jonathan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(loganjerry@gmail. | |com) --- Comment #5 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > - There are several build warnings that indicate possible runtime issues. > The -Wrestrict warnings indicate code that can produce garbled output. > The -Wformat-overflow warnings indicate possible buffer overflows. I'll gather some info and report this to upstream. > - The -Os flag to gcc should not be used, since Fedora has selected -O2. I don't think there's anything in packaging guidelines prohibiting overriding some of the default flags. In fact, guidelines say it's permissible. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags "It's not worth maintaining a patch for it" seems like reasonable justification IMO considering the trivial difference between -O2 and -Os. Regardless, I've created a patch to handle this and opened a PR upstream to see if upstream will change to O2 so we don't have to maintain a patch. > - Version 0.4.8 has been released, and includes your PR. Updated Spec URL: https://jonathanspw.fedorapeople.org/cinfo.spec SRPM URL: https://jonathanspw.fedorapeople.org/cinfo-0.4.8-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120002 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
