https://bugzilla.redhat.com/show_bug.cgi?id=2051066 --- Comment #2 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Hello Jakub, Thanks for the review! > The licensecheck found following: All 3 files are wayland protocol definitions which are not linked directly into the binary. These are processed with `wayland-scanner` to a C source and the existing practice was to consider these generated sources licensed the same as the main project. I'm going to add a following comment above the License tag, based on what we have in wlroots.spec: # The main source is MIT # The included wayland protocol files: # external/river-status-unstable-v1.xml: ISC # external/wlr-foreign-toplevel-management-unstable-v1.xml: HPND-sell-variant # external/wlr-layer-shell-unstable-v1.xml: HPND-sell-variant # Those files are processed to C-compilable files by the # `wayland-scanner` binary during build and don't alter # the main license of the binaries linking with them by # the underlying licenses. > The release number for older versions is unexpected. I don't see any > reason why to deviate from the "Simple versioning" scheme here I've been maintaining the package in my copr for wayland-related things for a while. Pre-release versioning ensures that if I import the package into Fedora repos with the proper Release tag, it will have a higher NVR and will seamlessly replace the copr build (and it looks like I forgot to do that for 1.8.0 :( ). I'm not going to preserve the changelog from copr anyways, as it does not carry any information useful for Fedora. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051066 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
