https://bugzilla.redhat.com/show_bug.cgi?id=2051066 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Aleksei, thank you for the package. I tested it on X11 and it works for me. I am not very familiar with the yambar project and C programming, so if you please can help me here - The licensecheck found following: ISC License ----------- yambar/external/river-status-unstable-v1.xml MIT License ----------- yambar/LICENSE NTP License (legal disclaimer) Historical Permission Notice and Disclaimer - sell variant ----------------------------------------------------------------------------------------- yambar/external/wlr-foreign-toplevel-management-unstable-v1.xml yambar/external/wlr-layer-shell-unstable-v1.xml Should we mention it in the License field? > * Sun Sep 12 2021 Aleksei Bavshin <alebastr@xxxxxxxxxxxxxxxxx> - 1.7.0-0.1 > * Mon Jul 26 2021 Aleksei Bavshin <alebastr@xxxxxxxxxxxxxxxxx> - 1.6.2-0.1 The release number for older versions is unexpected. I don't see any reason why to deviate from the "Simple versioning" scheme here https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_simple_versioning > Use a Release: tag starting with 1 (never 0). Append the Dist > Tag. Increment the release (by 1) for each update you make. Reset to 1 > whenever you change Version:. But those are older changelog entries, and the current release and changelog entry is correct, so I think we don't need to change anything here. > %doc README.md examples/* Just a note (for me) - I wouldn't expect such example scripts in %doc, but other packages do this as well `find /usr/share/doc/ |grep "\.sh$"` so it's probably okay :-) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051066 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
