https://bugzilla.redhat.com/show_bug.cgi?id=2120272 --- Comment #5 from Kalev Lember <klember@xxxxxxxxxx> --- (In reply to Benson Muite from comment #4) > Comments: > a) Some of the generated documentation has different licenses, in particular > Apache 2.0, should this be documented at the top level of the spec file as > well? No, because all of the generated documentation that has different licenses is in a separate -doc subpackage and that subpackage already has 'License: LGPL-2.1-or-later AND (Apache-2.0 OR GPL-3.0-or-later'). Somewhat confusingly, the "top level" license only applies to the binary libshumate package produced by the srpm (and also the -devel subpackage which inherits the license tag from the main package), but it's not a "top level" license in the sense that it's supposed to cover all the code in all of the subpackages. In this case, the -doc binary package has a different license from the libshumate binary package and that's fine; they really contain differently licensed code. > b) license file is in libshumate and libshumate-doc, assume this is so the > documentation can be installed on its own? Yes. All independent subpackages are supposed to ship the license files. > c) Documentation contains javascript, but there seems to be no way to avoid > this. > d) Is it possible to add a %check section with `meson test`? Sure, let me add that, good catch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120272 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
