https://bugzilla.redhat.com/show_bug.cgi?id=2120272 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file shumate-license.h is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License v2.1 or later", "GNU Library General Public License v2 or later", "*No copyright* [generated file]". 43 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/libshumate/2120272-libshumate/licensecheck.txt [?]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gir-1.0(libgdata- devel, libjcat-devel, libxmlb-devel, GConf2-devel, ibus-devel, fcitx5-gtk-devel, libsoup-devel, gnome-calculator-devel, gplugin- gtk4-devel, colord-gtk-devel, libarrow-dataset-glib-devel, graphene- devel, javascriptcoregtk4.0-devel, libmypaint-devel, libsecret-devel, gsound-devel, gdm-devel, libpanel-devel, gtksourceview5-devel, gegl04-devel, webkit2gtk4.1-devel, gtk4-devel, libmash-devel, gdk- pixbuf2-devel, geoclue2-devel, gplugin-devel, grilo-devel, gtk3-devel, gtk2-devel, tracker-devel, gucharmap-devel, libgnome-keyring-devel, libgepub-devel, appstream-devel, gfbgraph-devel, gtksourceview4-devel, malcontent-devel, gobject-introspection-devel, libinsane-gobject- devel, libcryptui-devel, libgee06-devel, vips-devel, amtk-devel, gupnp-devel, harfbuzz-devel, vte-devel, json-glib-devel, libmanette- devel, babl-devel, atk-devel, libgxps-devel, clapper-devel, totem-pl- parser-devel, gitg-devel, libhandy-devel, template-glib-devel, libgee- devel, gnome-bluetooth3.34-libs-devel, gssdp-devel, zbar-gi, libadwaita-devel, gupnp-av-devel, malcontent-ui-devel, webkit2gtk4.0-devel, vte291-devel, gspell-devel, javascriptcoregtk4.1-devel, gnome-autoar-devel, libsoup3-devel, gstreamer1-rtsp-server-devel, gplugin-gtk3-devel, libgexiv2-devel, jsonrpc-glib-devel, bamf-devel, libdmapsharing4-devel, glade-devel, rygel-devel, librsvg2-devel, gcr3-devel, gnome-bluetooth-libs-devel, gsequencer-devel, clutter-devel, libgdl-devel, libmodulemd-devel, libchamplain-devel, libarrow-glib-devel, libxklavier-devel, gnome- online-accounts-devel, libgtop2-devel, gnome-menus-devel, goocanvas2-devel, gupnp-dlna-devel, gupnp-igd-devel, parquet-glib- devel, fcitx-devel, javascriptcoregtk5.0-devel, gmime30-devel, webkit2gtk5.0-devel, gst-devtools-devel, libdazzle-devel, libpeas- devel, at-spi2-core-devel, libmodulemd1-devel), /usr/share/vala(gmime- devel, rygel-devel, libgdata-devel, libjcat-devel, librsvg2-devel, gcr3-devel, gitg-devel, libgit2-glib-devel, ibus-devel, tracker-devel, libcanberra-devel, libgnome-games-support-devel, libgnome-keyring- devel, libhandy-devel, libsoup-devel, libtranslit-devel, gnome- calculator-devel, appstream-devel, libgda5-devel, template-glib-devel, gtksourceview4-devel, libgee-devel, pulseaudio-libs-devel, gssdp- devel, gupnp-av-devel, libdmapsharing-devel, libgda-ui-devel, folks- devel, libsecret-devel, gsound-devel, vte291-devel, dconf-devel, gspell-devel, gtksourceview3-devel, gnome-online-accounts-devel, libpanel-devel, libgee06-devel, caribou-devel, gtksourceview5-devel, gnome-autoar-devel, libgweather-devel, vala, libsoup3-devel, gupnp- dlna-devel, gedit-devel, gegl04-devel, libgexiv2-devel, gupnp-devel, libgda-devel, zeitgeist-devel, gmime30-devel, libmanette-devel, geoclue2-devel, babl-devel, libdazzle-devel, libgweather4-devel, rhythmbox-devel, grilo-devel, gplugin-vala, jsonrpc-glib-devel, libgda5-ui-devel, bamf-devel, libdmapsharing4-devel, libosinfo-devel), /usr/share/vala/vapi(gmime-devel, rygel-devel, libgdata-devel, libjcat-devel, librsvg2-devel, gcr3-devel, gitg-devel, libgit2-glib- devel, ibus-devel, tracker-devel, libcanberra-devel, libgnome-games- support-devel, libgnome-keyring-devel, libhandy-devel, libsoup-devel, libtranslit-devel, gnome-calculator-devel, appstream-devel, libgda5-devel, template-glib-devel, gtksourceview4-devel, libgee- devel, pulseaudio-libs-devel, gssdp-devel, gupnp-av-devel, libdmapsharing-devel, libgda-ui-devel, folks-devel, libsecret-devel, libzeitgeist-devel, gsound-devel, vte291-devel, dconf-devel, gspell- devel, gtksourceview3-devel, gnome-online-accounts-devel, libpanel- devel, libgee06-devel, caribou-devel, gtksourceview5-devel, gnome- autoar-devel, libgweather-devel, vala, libsoup3-devel, gupnp-dlna- devel, gedit-devel, gegl04-devel, libgexiv2-devel, gupnp-devel, libgda-devel, zeitgeist-devel, gmime30-devel, libmanette-devel, geoclue2-devel, babl-devel, libdazzle-devel, libgweather4-devel, rhythmbox-devel, grilo-devel, gplugin-vala, jsonrpc-glib-devel, fwupd- devel, bamf-devel, libgda5-ui-devel, libdmapsharing4-devel, libosinfo- devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libshumate-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://download.gnome.org/sources/libshumate/1.0/libshumate-1.0.0.alpha.1.tar.xz : CHECKSUM(SHA256) this package : 2bc56f16cf89369e49a1e6bbb0caad6362fbfaa124435a083e7a0ac2438e0b49 CHECKSUM(SHA256) upstream package : 2bc56f16cf89369e49a1e6bbb0caad6362fbfaa124435a083e7a0ac2438e0b49 Requires -------- libshumate (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgraphene-1.0.so.0()(64bit) libgtk-4.so.1()(64bit) libm.so.6()(64bit) libsoup-3.0.so.0()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH) libshumate-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libshumate(x86-64) libshumate-1.0.so.1()(64bit) pkgconfig(cairo) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(gtk4) pkgconfig(libsoup-3.0) pkgconfig(sqlite3) libshumate-doc (rpmlib, GLIBC filtered): libshumate-debuginfo (rpmlib, GLIBC filtered): libshumate-debugsource (rpmlib, GLIBC filtered): Provides -------- libshumate: libshumate libshumate(x86-64) libshumate-1.0.so.1()(64bit) libshumate-devel: libshumate-devel libshumate-devel(x86-64) pkgconfig(shumate-1.0) libshumate-doc: libshumate-doc libshumate-debuginfo: debuginfo(build-id) libshumate-1.0.so.1.0-1.0.0~alpha.1-3.fc38.x86_64.debug()(64bit) libshumate-debuginfo libshumate-debuginfo(x86-64) libshumate-debugsource: libshumate-debugsource libshumate-debugsource(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/benson/Projects/FedoraPackaging/libshumate/2120272-libshumate/srpm/libshumate.spec 2022-08-23 11:13:09.011100335 +0300 +++ /home/benson/Projects/FedoraPackaging/libshumate/2120272-libshumate/srpm-unpacked/libshumate.spec 202 2-08-22 21:06:16.000000000 +0300 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.0) +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 3; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global tarball_version %%(echo %{version} | tr '~' '.') @@ -88,3 +97,12 @@ %changelog -%autochangelog +* Mon Aug 22 2022 Kalev Lember <klember@xxxxxxxxxx> 1.0.0~alpha.1-3 +- Split developer docs out to -doc subpackage (rhbz#2120272) +- Fix license tag for the -doc subpackage + +* Mon Aug 22 2022 Kalev Lember <klember@xxxxxxxxxx> 1.0.0~alpha.1-2 +- Correct license tag to LGPL-2.1-or-later AND LGPL-2.0-or-later + (rhbz#2120272) + +* Mon Aug 22 2022 Kalev Lember <klember@xxxxxxxxxx> 1.0.0~alpha.1-1 +- Initial Fedora packaging Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2120272 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, Ocaml, Perl, SugarActivity, Python, Haskell, Java, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint libshumate-doc-1.0.0~alpha.1-3.fc38.noarch.rpm ========================================== rpmlint session starts ========================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 libshumate-doc.noarch: W: invalid-license LGPL-2.1-or-later libshumate-doc.noarch: W: invalid-license Apache-2.0 libshumate-doc.noarch: W: invalid-license GPL-3.0-or-later =========== 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.7 s ========== $ rpmlint libshumate-debuginfo-1.0.0~alpha.1-3.fc38.x86_64.rpm ========================================== rpmlint session starts ========================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 libshumate-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libshumate-1.0.so.1.0g libshumate-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/libg libshumate-debuginfo.x86_64: W: invalid-license LGPL-2.1-or-later libshumate-debuginfo.x86_64: W: invalid-license LGPL-2.0-or-later libshumate-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/7a/02742bd51051eaac3d71d =========== 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.8 s ========== $ rpmlint libshumate-1.0.0~alpha.1-3.fc38.src.rpm ========================================== rpmlint session starts ========================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 libshumate.src: W: strange-permission libshumate.spec 600 libshumate.src: W: invalid-license LGPL-2.1-or-later libshumate.src: W: invalid-license LGPL-2.0-or-later =========== 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.8 s ========== Comments: a) Some of the generated documentation has different licenses, in particular Apache 2.0, should this be documented at the top level of the spec file as well? b) license file is in libshumate and libshumate-doc, assume this is so the documentation can be installed on its own? c) Documentation contains javascript, but there seems to be no way to avoid this. d) Is it possible to add a %check section with `meson test`? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120272 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
