https://bugzilla.redhat.com/show_bug.cgi?id=2010172 --- Comment #2 from Jens Petersen <petersen@xxxxxxxxxx> --- Hi Jakub, Thanks for looking at the package (In reply to Jakub Kadlčík from comment #1) > I installed it and it works as expected. Cool > > # generated by cabal-rpm-2.0.10 > > # Begin cabal-rpm sources: > > # End cabal-rpm deps > > ... > > Can you please remove all these automatically generated comments? I can remove them, though they are generated intentionally by the cabal-rpm packaging tool. Particularly the first line, used to record the version, allows updates to newer cabal-rpm versions to be done more easily. The Begin/End delimiter comments are there to help reduce patch conflicts when updating the package. > > %{buildroot}%{_bindir}/%{name} --bash-completion-script %{name} | sed s/filenames/default/ > %{buildroot}%{_datadir}/bash-completion/completions/%{name} > > Can you please add a comment explaining what we need the `sed` for? Sure good idea. > Also, the line is quite long, this might be more readable > > %{buildroot}%{_bindir}/%{name} --bash-completion-script %{name} \ > | sed s/filenames/default/ \ > > %{buildroot}%{_datadir}/bash-completion/completions/%{name} Okay, I can change it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010172 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
