https://bugzilla.redhat.com/show_bug.cgi?id=2010172 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Jens, thank you for the package. I installed it and it works as expected. There are just a few minor things that I would like to propose. > # generated by cabal-rpm-2.0.10 > # Begin cabal-rpm sources: > # End cabal-rpm deps > ... Can you please remove all these automatically generated comments? > %{buildroot}%{_bindir}/%{name} --bash-completion-script %{name} | sed s/filenames/default/ > %{buildroot}%{_datadir}/bash-completion/completions/%{name} Can you please add a comment explaining what we need the `sed` for? Also, the line is quite long, this might be more readable %{buildroot}%{_bindir}/%{name} --bash-completion-script %{name} \ | sed s/filenames/default/ \ > %{buildroot}%{_datadir}/bash-completion/completions/%{name} but that's just a suggestion, it's up to you what you prefer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010172 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
