https://bugzilla.redhat.com/show_bug.cgi?id=2076836 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |jkadlcik@xxxxxxxxxx --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Gustavo, thank you for the package. I tried to install and run it, and it works for me. The spec file is also very well written. I found just a couple of minor things. > # The entire source code is GPLv3+ except for > # the shunting-yard code and its test which are BSD 2-Clause Perfect, I just wanted to say I like the explanation :-) I also found a BSD license in inc/stack.h so we should probably mention that in the comment as well. > License: GPLv3+ and BSD Looking at the license, I think it is GPLv3, not GPLv3+ . Do you agree? Maybe I am misreading it. > %license COPYING There is also LICENSE so we should IMHO install both of them > BuildRequires: pkgconfig(ncurses) > BuildRequires: pkgconfig(readline) > BuildRequires: pkgconfig(cunit) TIL that there is this pkgconfig macro, thanks :-) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2076836 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
