https://bugzilla.redhat.com/show_bug.cgi?id=2120012 Jonathan Wright <jonathan@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #3 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > a) In the description perhaps remove "For the uninitiated", as it does not > add value. Perhaps also indicate that this is a header only library. Good point, done. > b) The sources include static executables in the test directory. This > directory should be excluded from the packaged header only library, and the > directories to be packaged explicitly listed in the spec file, using just > jwt/include seems inappropriate. These executables are not in the resulting package. [jonathan@jon-fedora-build jwt]$ pwd /usr/include/jwt [jonathan@jon-fedora-build jwt]$ ls -l test total 0 I've excluded this empty dir in the spec file for clarity. Specifying all of %{_includedir}/jwt/ seems appropriate to me based on packaging guidelines since everything here is owned by this package. Why get more specific? It's not a generic glob which is what guidelines forbid. > c) Should the examples be packaged as part of the documentation? I toyed with that idea but the cmake scripts don't install them anywhere as-is and I didn't feel it worth patching in because there are some examples in the readme. > d) The folder include/jwt/json contains test_json.cc , does this need to be > packaged? Nope. Spec URL: https://jonathanspw.fedorapeople.org/cpp-jwt.spec SRPM URL: https://jonathanspw.fedorapeople.org/cpp-jwt-1.4-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120012 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
