https://bugzilla.redhat.com/show_bug.cgi?id=2112474 --- Comment #30 from John Snow <jsnow@xxxxxxxxxx> --- Thank you for your review. OK; Draft V4: https://people.redhat.com/~jsnow/v4/python-qemu-qmp.spec Draft SRPM: https://people.redhat.com/~jsnow/v4/python-qemu-qmp-0.0.2.dev14+g7f9a044-1.fc36.src.rpm - Added gnupg2 builddep (Not sure why it was working before, but it's there now...) - Sorted BuildRequires alphabetically - Reworded description slightly to avoid some redundancy -- Kashyap: If you want to reword it more aggressively, please send me a MR on GitLab O:-) -- I agree it needs some more work, but I want to keep it in sync with upstream. - Added some newlines before `%description` - Use "%package doc" spelling for subpackage - Rephrase on qmp-tui exclusion comment (f36 added the missing dep, so don't blame that.) - Touch up install command for manpages to preserve timestamp and use single invocation - Remove RFC commend and shorten env vars around running avocado in %check - Update changelog timestamp and version If it looks OK, I'll cut v0.0.2 upstream and post a final draft with the final correct versions and URLs. Thanks, --js -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2112474 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
