https://bugzilla.redhat.com/show_bug.cgi?id=2115901 --- Comment #4 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- Thanks for taking a look. (In reply to Aleksei Bavshin from comment #3) > > BuildRequires: mesa-libGL-devel > > You'll likely want `libglvnd-devel` instead, as it is the actual provider of > OpenGL headers/libraries. Fixed. > > > # [11:38 AM] WerWolv: Officially supported are x86_64 and aarch64 > > ExcludeArch: i686 > > ExcludeArch: armv7hl > > %{ix86} and %{arm32} correspondingly. But given the upstream support status, > it would make sense to do `ExclusiveArch: x86_64 %{arm64}`. And ppc64le if > you are sure it works there. Swapped to using ExclusiveArch and macros where possible. > > make -C redhat-linux-build -j unit_tests > > Both `make` and `redhat-linux-build` are %cmake macro implementation details > that may change. Maybe `%cmake_build -- --target unit_tests` would work? Indeed this works! Thank you! > - Please, also declare `Provides: bundled()` for all third-party libraries > built in the package: yara (conditionally), capstone, imgui, libromfs, > microtar, nativefiledialog, pattern_language, xdgpp... Now that I listed all > of that, I feel that the License tag is incomplete :) > Also, consider unbundling at least some of those. Do they need to be listed as bundled even if none of them actually end up installed in the filesystem anywhere and are only used to build? This application is very bleeding edge in terms of the libs it uses and some of the things simply can't be packaged separately yet. capstone for example hasn't release v5 but the packaged version is basically v5 which is required for ImHex. A few of the other things like pattern_language and libromfs I fully intend to package separately. They're from the same upstream developer so I was planning to do that a bit later on as to not delay getting this package itself into the repos. Upstream has to do some work to permit system libs for some of these things to be used such as proper versioning and releases. All possible system libs are being used with the cmake flags currently. yara is about to be non-conditional too as the latest yara is being pushed back to f36 I'm just waiting on bodhi to push it to stable. > - As it is a GUI app, it should provide an AppStream metainfo file > (otherwise you won't be able to find and install ImHex with gnome-software). > See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ Added. Thanks for all your suggestions. Spec URL: https://jonathanspw.fedorapeople.org/ImHex.spec SRPM URL: https://jonathanspw.fedorapeople.org/ImHex-1.20.0-3.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2115901 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
