https://bugzilla.redhat.com/show_bug.cgi?id=2115901 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@xxxxxxxxx --- Comment #3 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- > BuildRequires: mesa-libGL-devel You'll likely want `libglvnd-devel` instead, as it is the actual provider of OpenGL headers/libraries. > # [11:38 AM] WerWolv: Officially supported are x86_64 and aarch64 > ExcludeArch: i686 > ExcludeArch: armv7hl %{ix86} and %{arm32} correspondingly. But given the upstream support status, it would make sense to do `ExclusiveArch: x86_64 %{arm64}`. And ppc64le if you are sure it works there. > make -C redhat-linux-build -j unit_tests Both `make` and `redhat-linux-build` are %cmake macro implementation details that may change. Maybe `%cmake_build -- --target unit_tests` would work? - Please, also declare `Provides: bundled()` for all third-party libraries built in the package: yara (conditionally), capstone, imgui, libromfs, microtar, nativefiledialog, pattern_language, xdgpp... Now that I listed all of that, I feel that the License tag is incomplete :) Also, consider unbundling at least some of those. - As it is a GUI app, it should provide an AppStream metainfo file (otherwise you won't be able to find and install ImHex with gnome-software). See https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2115901 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
