https://bugzilla.redhat.com/show_bug.cgi?id=2115066 Otto Liljalaakso <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #2 from Otto Liljalaakso <oturpe@xxxxxx> --- (In reply to Salman Butt from comment #1) > UNOFFICIAL REVIEW: > ------------------ Thank you for the feedback! > POSSIBLE ISSUES: > > Diff spec file in url and in SRPM. > May need to check re upload the specfile Yes, something was wrong. I updated the description and bumped release. Latest specfile and rpm are here: Spec URL: http://oturpe.kapsi.fi/fedora/rpms/yle-dl/yle-dl.spec SRPM URL: http://oturpe.kapsi.fi/fedora/rpms/yle-dl/yle-dl-20220704-2.fc37.src.rpm > Requires: /usr/bin/ffmpeg > Will possibly be need to be changed to ffpmeg-free > > Recommends: /usr/bin/wget > Will possibly be need to be changed to wget > > However file/dir dependency is valid: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_file_and_directory_dependencies > Will leave it to the official reviewer Requiring ffmpeg-free would prevent using this package together with the full features ffmpeg from RPM Fusion. Compatibility with RPM Fusion is the main reason for depending on the executable file; both ffmpeg and ffmpeg-free provide that binary, so either can satisfy this Require. Also, yle-dl uses ffmpeg by invoking the ffmpeg executable, so in that sense the file dependency is the most correct way to express the dependency. The case of wget is similar, except the RPM Fusion argument does not apply. I put it as file dependency because the case is similar to ffmpeg, and because of the 'most correct way' argument. Changing to "Required: wget" would work here, so I can change to that if requested. > Licnese Unknown or generated > -------------------- > yle-dl-20220704/COPYING > yle-dl-20220704/MANIFEST.in > yle-dl-20220704/README.fi > yle-dl-20220704/setup.cfg > yle-dl-20220704/tests/conftest.py > yle-dl-20220704/tests/integration/test_areena_it.py > yle-dl-20220704/tests/integration/test_areena_radio_it.py > yle-dl-20220704/tests/integration/test_arkisto_it.py > yle-dl-20220704/tests/integration/test_arkivet_it.py > yle-dl-20220704/tests/integration/test_uutiset_it.py > yle-dl-20220704/tests/test_backend.py > yle-dl-20220704/tests/test_downloader.py > yle-dl-20220704/tests/test_flavor_filters.py > yle-dl-20220704/tests/test_timestamp.py > yle-dl-20220704/tests/test_title_formatter.py > yle-dl-20220704/tests/utils.py > yle-dl-20220704/yle_dl.egg-info/SOURCES.txt > yle-dl-20220704/yle_dl.egg-info/dependency_links.txt > yle-dl-20220704/yle_dl.egg-info/entry_points.txt > yle-dl-20220704/yle_dl.egg-info/requires.txt > yle-dl-20220704/yle_dl.egg-info/top_level.txt > yle-dl-20220704/yledl/__init__.py > yle-dl-20220704/yledl/__main__.py > yle-dl-20220704/yledl/backends.py > yle-dl-20220704/yledl/downloader.py > yle-dl-20220704/yledl/errors.py > yle-dl-20220704/yledl/exitcodes.py > yle-dl-20220704/yledl/extractors.py > yle-dl-20220704/yledl/ffprobe.py > yle-dl-20220704/yledl/geolocation.py > yle-dl-20220704/yledl/http.py > yle-dl-20220704/yledl/io.py > yle-dl-20220704/yledl/kaltura.py > yle-dl-20220704/yledl/localization.py > yle-dl-20220704/yledl/streamfilters.py > yle-dl-20220704/yledl/streamflavor.py > yle-dl-20220704/yledl/streamprobe.py > yle-dl-20220704/yledl/subtitles.py > yle-dl-20220704/yledl/timestamp.py > yle-dl-20220704/yledl/titleformatter.py > yle-dl-20220704/yledl/utils.py > yle-dl-20220704/yledl/version.py I have suggested some license clarification upstream: https://github.com/aajanki/yle-dl/pull/326 I did not touch the case of many source files no having a license header. Apparently, upstream thinking is that they explain the project license in top level files such as README.md, and the main source file yledl/yledl.py, and the rest are considered to be implictly under the project license. I will add a comment to my pull request, asking upstream to consider adding license headers to every source file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2115066 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
