https://bugzilla.redhat.com/show_bug.cgi?id=2115066 Salman Butt <cn137@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cn137@xxxxxxxxxxxxxx --- Comment #1 from Salman Butt <cn137@xxxxxxxxxxxxxx> --- UNOFFICIAL REVIEW: ------------------ POSSIBLE ISSUES: Diff spec file in url and in SRPM. May need to check re upload the specfile --------------------------------- --- /review-yle-dl/srpm/yle-dl.spec 2022-08-03 22:15:29.014435833 -0400 +++ /review-yle-dl/srpm-unpacked/yle-dl.spec 2022-08-03 15:19:53.000000000 -0400 @@ -16,5 +16,5 @@ @IBLE %description -Command-line program for downloading media files from the three video +yle-dl is a command-line program for downloading media files from the two video streaming services of the Finnish national broadcasting company Yle: Yle Areena, Elävä arkisto, and Yle news. ----------------------------------- Requires: /usr/bin/ffmpeg Will possibly be need to be changed to ffpmeg-free Recommends: /usr/bin/wget Will possibly be need to be changed to wget However file/dir dependency is valid: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_dependencies Will leave it to the official reviewer ---------------------------------------------------- Licnese Unknown or generated -------------------- yle-dl-20220704/COPYING yle-dl-20220704/MANIFEST.in yle-dl-20220704/README.fi yle-dl-20220704/setup.cfg yle-dl-20220704/tests/conftest.py yle-dl-20220704/tests/integration/test_areena_it.py yle-dl-20220704/tests/integration/test_areena_radio_it.py yle-dl-20220704/tests/integration/test_arkisto_it.py yle-dl-20220704/tests/integration/test_arkivet_it.py yle-dl-20220704/tests/integration/test_uutiset_it.py yle-dl-20220704/tests/test_backend.py yle-dl-20220704/tests/test_downloader.py yle-dl-20220704/tests/test_flavor_filters.py yle-dl-20220704/tests/test_timestamp.py yle-dl-20220704/tests/test_title_formatter.py yle-dl-20220704/tests/utils.py yle-dl-20220704/yle_dl.egg-info/SOURCES.txt yle-dl-20220704/yle_dl.egg-info/dependency_links.txt yle-dl-20220704/yle_dl.egg-info/entry_points.txt yle-dl-20220704/yle_dl.egg-info/requires.txt yle-dl-20220704/yle_dl.egg-info/top_level.txt yle-dl-20220704/yledl/__init__.py yle-dl-20220704/yledl/__main__.py yle-dl-20220704/yledl/backends.py yle-dl-20220704/yledl/downloader.py yle-dl-20220704/yledl/errors.py yle-dl-20220704/yledl/exitcodes.py yle-dl-20220704/yledl/extractors.py yle-dl-20220704/yledl/ffprobe.py yle-dl-20220704/yledl/geolocation.py yle-dl-20220704/yledl/http.py yle-dl-20220704/yledl/io.py yle-dl-20220704/yledl/kaltura.py yle-dl-20220704/yledl/localization.py yle-dl-20220704/yledl/streamfilters.py yle-dl-20220704/yledl/streamflavor.py yle-dl-20220704/yledl/streamprobe.py yle-dl-20220704/yledl/subtitles.py yle-dl-20220704/yledl/timestamp.py yle-dl-20220704/yledl/titleformatter.py yle-dl-20220704/yledl/utils.py yle-dl-20220704/yledl/version.py ------ Not going to comment on any python, since im not an expert. Hope this helps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2115066 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
