https://bugzilla.redhat.com/show_bug.cgi?id=2114603 --- Comment #13 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- (In reply to Miro Hrončok from comment #12) > (discarding %doc, %license and epel8 for readability) > > ================================================ > %files -n python3-kgb > %{python3_sitelib}/kgb/*.py > %{python3_sitelib}/kgb/__pycache__/ > %{python3_sitelib}/kgb-%{version}.dist-info/ > > %files -n python3-kgb-tests > %{python3_sitelib}/kgb/tests > ================================================ > > This means nothing owns %{python3_sitelib}/kgb/ > > You can fix that by: > > ================================================ > %files -n python3-kgb > %dir %{python3_sitelib}/kgb/ > %{python3_sitelib}/kgb/*.py > %{python3_sitelib}/kgb/__pycache__/ > %{python3_sitelib}/kgb-%{version}.dist-info/ > > %files -n python3-kgb-tests > %{python3_sitelib}/kgb/tests > ================================================ > > Or better yet: > > ================================================ > %files -n python3-kgb > %{python3_sitelib}/kgb/ > %exclude %{python3_sitelib}/kgb/tests/ > %{python3_sitelib}/kgb-%{version}.dist-info/ > > %files -n python3-kgb-tests > %{python3_sitelib}/kgb/tests/ > ================================================ I thought this is how it should be (less the exclude part, wasn't aware of that macro) but I thought you said don't do it above (quoted below)? Perhaps I misunderstood what you meant. ----- > > %dir %{python3_sitelib}/kgb > > %{python3_sitelib}/kgb/* > > This does not look like a namespace package. I'd use simpler: > > %{python3_sitelib}/kgb/ ----- > ================================================ > %package -n python3-kgb-tests > Summary: Unit tests for python3-kgb > Requires: python3-kgb > BuildRequires: python3-pytest > BuildRequires: python3-six > ================================================ > > 1) Use `Requires: python3-kgb = %{version}-%{release} > 2) I'd not personally hide the buildrequires here > 3) should that package require six on runtime if it needs it on buildtime? 1) Done 2) Moved back to main section with the other BuildRequires. 3) six is actually not required at all. Spec URL: https://jonathanspw.fedorapeople.org/python-kgb.spec SRPM URL: https://jonathanspw.fedorapeople.org/python-kgb-7.0-4.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2114603 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
