https://bugzilla.redhat.com/show_bug.cgi?id=2114603 --- Comment #12 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (discarding %doc, %license and epel8 for readability) ================================================ %files -n python3-kgb %{python3_sitelib}/kgb/*.py %{python3_sitelib}/kgb/__pycache__/ %{python3_sitelib}/kgb-%{version}.dist-info/ %files -n python3-kgb-tests %{python3_sitelib}/kgb/tests ================================================ This means nothing owns %{python3_sitelib}/kgb/ You can fix that by: ================================================ %files -n python3-kgb %dir %{python3_sitelib}/kgb/ %{python3_sitelib}/kgb/*.py %{python3_sitelib}/kgb/__pycache__/ %{python3_sitelib}/kgb-%{version}.dist-info/ %files -n python3-kgb-tests %{python3_sitelib}/kgb/tests ================================================ Or better yet: ================================================ %files -n python3-kgb %{python3_sitelib}/kgb/ %exclude %{python3_sitelib}/kgb/tests/ %{python3_sitelib}/kgb-%{version}.dist-info/ %files -n python3-kgb-tests %{python3_sitelib}/kgb/tests/ ================================================ ================================================ %package -n python3-kgb-tests Summary: Unit tests for python3-kgb Requires: python3-kgb BuildRequires: python3-pytest BuildRequires: python3-six ================================================ 1) Use `Requires: python3-kgb = %{version}-%{release} 2) I'd not personally hide the buildrequires here 3) should that package require six on runtime if it needs it on buildtime? ================================================ %files -n python3-kgb-tests %license LICENSE ... ================================================ There is no need for the LICENSE file here, see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2114603 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
