https://bugzilla.redhat.com/show_bug.cgi?id=2112474 --- Comment #1 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- Hiya! Good start :-). A couple of small things: (1) I think you intended to remove the commented-out old macros # (pct)py3_build ... # (pct)py3_install Thanks for reworking the spec to use newer macros! (2) `rpmlint` complains about macro in comment: $> rpmlint python-qemu-qmp.spec ../SRPMS/python-qemu-qmp-0.0.1-1.fc36.src.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python-qemu-qmp.spec:50: W: macro-in-comment %{pypi_name} python-qemu-qmp.spec:50: W: macro-in-comment %{pypi_name} ==================================================== 1 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.8 s ==================================================== (3) [INFO] The Koji scratch build succeeds; nice: ----------------------------------------------------------------------- $> koji build --scratch rawhide ../SRPMS/python-qemu-qmp-0.0.1-1.fc36.src.rpm Uploading srpm: ../SRPMS/python-qemu-qmp-0.0.1-1.fc36.src.rpm [====================================] 100% 00:00:00 96.37 KiB 232.47 KiB/sec Created task: 90346957 Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=90346957 Watching tasks (this may be safely interrupted)... 90346957 build (rawhide, python-qemu-qmp-0.0.1-1.fc36.src.rpm): free 90346957 build (rawhide, python-qemu-qmp-0.0.1-1.fc36.src.rpm): free -> open (buildvm-s390x-24.s390.fedoraproject.org) 90346963 rebuildSRPM (noarch): open (buildvm-s390x-24.s390.fedoraproject.org) 90346997 buildArch (python-qemu-qmp-0.0.1-1.fc37.src.rpm, noarch): open (buildvm-s390x-29.s390.fedoraproject.org) 90346963 rebuildSRPM (noarch): open (buildvm-s390x-24.s390.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 90346997 buildArch (python-qemu-qmp-0.0.1-1.fc37.src.rpm, noarch): open (buildvm-s390x-29.s390.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 90346957 build (rawhide, python-qemu-qmp-0.0.1-1.fc36.src.rpm): open (buildvm-s390x-24.s390.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 90346957 build (rawhide, python-qemu-qmp-0.0.1-1.fc36.src.rpm) completed successfully ----------------------------------------------------------------------- (4) [TODO] We need to get someone more well-versed in licensing to review the license "RFC" comment you put in the spec. (5) Super nit: Usually, along with link to RPM spec, the review-request submitter also posts a link to the SRPM. But it's not a big deal. * * * Meanwhile, /me goes to run: $> fedora-review -m fedora-rawhide-x86_64 \ --rpm-spec -n ~/rpmbuild/SRPMS/python-qemu-qmp-0.0.1-1.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2112474 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
