[Bug 2089243] Review Request: python-mbstrdecoder - multi-byte character string decoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2089243



--- Comment #14 from José Matos <jamatos@xxxxxxxx> ---
OK, the issue now is that the package requires python-chardet.

You can see that in requirements/requirements.txt it has the following content:
chardet>=3.0.4,<5

Interestingly in June Miro orphaned the package:
https://lists.fedoraproject.org/archives/list/python-devel@xxxxxxxxxxxxxxxxxxxxxxx/message/QCCBDPEONUGX2BU5L7ODCIJPBHJ6SIM2/

The package was picked and was updated to version 5.0.0:
https://src.fedoraproject.org/rpms/python-chardet

I picked this since the reviews should be done against rawhide, for all the
other releases this is not an issue.

My suggestion is to check if this package works with chardet >= 5 and in that
case please patch the requirements file to remove the ,<5.

In my experience most of the time these dependencies are preventive and
unnecessary. There are naturally exceptions but you can try.
The easiest way to try is to build the package and see if there are any
failures in the tests.

>From the release notes there is not any red herring:
https://github.com/chardet/chardet/releases/tag/5.0.0

Again apologies for the delay, feel free to ask any question.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2089243
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux