[Bug 2106138] Review Request: pinnwand - Straightforward pastebin software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2106138

Lyes Saadi <fedora@xxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxx



--- Comment #2 from Lyes Saadi <fedora@xxxxxxx> ---
Hello!

I'm not really comfortable yet with the new Python packaging guidelines, so not
sure about reviewing this, but:

1. Use macros (%{_bindir} / %{_datadir}) for paths:
```
mkdir -p %{buildroot}/usr/share/pinnwand
cp -a pinnwand.service-example /%{buildroot}/usr/share/pinnwand/
cp -a pinnwand.toml-example /%{buildroot}/usr/share/pinnwand/
```
to
```
mkdir -p %{buildroot}%{_datadir}/pinnwand
cp -a pinnwand.service-example %{buildroot}%{_datadir}/pinnwand/
cp -a pinnwand.toml-example %{buildroot}%{_datadir}/pinnwand/
```
(also, removed the unnecessary / before the buildroot)

and

```
%files -f %{pyproject_files}
/usr/bin/pinnwand
/usr/share/pinnwand/pinnwand.service-example
/usr/share/pinnwand/pinnwand.toml-example
```
to
```
%files -f %{pyproject_files}
%{_bindir}/pinnwand
%{_datadir}/pinnwand/pinnwand.service-example
%{_datadir}/pinnwand/pinnwand.toml-example
```

2. Remove the -p1 in %autosetup (did you forget it there?)

3. The examples in share is "fine". I mean, choosing where to place them is
usually the job of upstream, but, since, well, you are upstream, that's your
choice. Usually, we'd put them with the documentation (with %doc) if upstream
decided not to install it themselves, but, putting it in /usr/share makes sense
looking at what other upstreams do.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2106138
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux